From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH] contrib: pick: use the sexp parser
Date: Sun, 02 Jun 2013 13:01:12 +0100 [thread overview]
Message-ID: <87sj10g1rr.fsf@qmul.ac.uk> (raw)
In-Reply-To: <m2r4gllfo6.fsf@guru.guru-group.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> These trivial changes look good -- is sexp already supported in show ?
At the moment sexp is not supported in show (despite that using
synchronous command so it is much easier). I posted a (not good) at
id:1354975891-24663-1-git-send-email-markwalters1009@gmail.com and in
Austin's reply he suggested a much better way of doing is. But I never posted a
corrected version (perhaps I was waiting for the error handling stuff to
clear?).
Best wishes
Mark
>
> Tomi
>
>>
>> contrib/notmuch-pick/notmuch-pick.el | 5 ++---
>> 1 files changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
>> index 128fabf..33905d6 100644
>> --- a/contrib/notmuch-pick/notmuch-pick.el
>> +++ b/contrib/notmuch-pick/notmuch-pick.el
>> @@ -773,8 +773,7 @@ Complete list of currently available key bindings:
>> (save-excursion
>> (goto-char (point-max))
>> (insert string))
>> - (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread
>> - 'notmuch-pick-show-error
>> + (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread
>> results-buf)))))
>>
>> (defun notmuch-pick-worker (basic-query &optional query-context target buffer)
>> @@ -796,7 +795,7 @@ Complete list of currently available key bindings:
>> (if notmuch-pick-asynchronous-parser
>> (let ((proc (start-process
>> "notmuch-pick" buffer
>> - notmuch-command "show" "--body=false" "--format=json"
>> + notmuch-command "show" "--body=false" "--format=sexp"
>> message-arg search-args))
>> ;; Use a scratch buffer to accumulate partial output.
>> ;; This buffer will be killed by the sentinel, which
>> --
>> 1.7.9.1
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-06-02 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-01 19:04 [PATCH] contrib: pick: use the sexp parser Mark Walters
2013-06-01 20:49 ` Tomi Ollila
2013-06-02 12:01 ` Mark Walters [this message]
2013-06-02 11:11 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj10g1rr.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).