From: Mark Walters <markwalters1009@gmail.com>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp'
Date: Mon, 24 Jun 2013 20:29:35 +0100 [thread overview]
Message-ID: <87sj07tihs.fsf@qmul.ac.uk> (raw)
In-Reply-To: <20130624191115.GB2214@mit.edu>
That is fine.
(I think I only moved your code from one file to another but in any case
what you suggest is fine.)
Best wishes
Mark
On Mon, 24 Jun 2013, Austin Clements <amdragon@MIT.EDU> wrote:
> Yes, and thanks for reminding me about the require's. I'll do that in
> a follow up. I was thinking of just moving the streaming JSON parser
> to a repo on my GitHub account, since maybe somebody some day will
> find a use for it, or at least take inspiration from the API (I looked
> into streaming JSON parser APIs before embarking on that one and
> they're all terrible!) Mark, you're the only other person who has
> touched that code. Is this plan good with you?
>
> Quoth Mark Walters on Jun 24 at 8:00 pm:
>>
>> This series looks good to me +1.
>>
>> Is it worth removing all the json (3 files with (require 'json) and the
>> async json parser) too?
>>
>> Best wishes
>>
>> Mark
>>
>> On Mon, 24 Jun 2013, Austin Clements <amdragon@MIT.EDU> wrote:
>> > This is just like `notmuch-call-notmuch-json', but parses S-expression
>> > output. Note that, also like `notmuch-call-notmuch-json', this
>> > doesn't consider trailing data to be an error, which may or may not be
>> > what we want in the long run.
>> > ---
>> > emacs/notmuch-lib.el | 17 +++++++++++++++++
>> > 1 file changed, 17 insertions(+)
>> >
>> > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
>> > index 534f217..36eacc1 100644
>> > --- a/emacs/notmuch-lib.el
>> > +++ b/emacs/notmuch-lib.el
>> > @@ -484,6 +484,23 @@ an error."
>> > (json-read)))
>> > (delete-file err-file)))))
>> >
>> > +(defun notmuch-call-notmuch-sexp (&rest args)
>> > + "Invoke `notmuch-command' with ARGS and return the parsed S-exp output.
>> > +
>> > +If notmuch exits with a non-zero status, this will pop up a
>> > +buffer containing notmuch's output and signal an error."
>> > +
>> > + (with-temp-buffer
>> > + (let ((err-file (make-temp-file "nmerr")))
>> > + (unwind-protect
>> > + (let ((status (apply #'call-process
>> > + notmuch-command nil (list t err-file) nil args)))
>> > + (notmuch-check-exit-status status (cons notmuch-command args)
>> > + (buffer-string) err-file)
>> > + (goto-char (point-min))
>> > + (read (current-buffer)))
>> > + (delete-file err-file)))))
>> > +
>> > (defun notmuch-start-notmuch (name buffer sentinel &rest args)
>> > "Start and return an asynchronous notmuch command.
next prev parent reply other threads:[~2013-06-24 19:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-23 23:43 [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp' Austin Clements
2013-06-23 23:43 ` [PATCH 2/3] emacs: Use S-exp format everywhere Austin Clements
2013-06-23 23:43 ` [PATCH 3/3] emacs: Remove `notmuch-call-notmuch-json' Austin Clements
2013-06-24 15:35 ` [PATCH 1/3] emacs: Introduce `notmuch-call-notmuch-sexp' Tomi Ollila
2013-06-24 19:00 ` Mark Walters
2013-06-24 19:11 ` Austin Clements
2013-06-24 19:29 ` Mark Walters [this message]
2013-06-25 6:06 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj07tihs.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).