[PATCH] test: set mail host in emacs_deliver

[PATCH] test: set mail host in emacs_deliver

[Mark Walters]

One test (reply to encrypted message in the crypto test) recently
started failing on some systems. The failure I saw were two extra
lines of the form
<87d2nbc5xg.fsf@host.i-did-not-set--mail-host-address--so-tickle-me>

The test pipes the output through

grep -v -e '^In-Reply-To:' -e '^References:'

which would normally these two ids but it does not, in this case,
because they are so long they get put on a separate line in the output.

To fix this we set mail-host-address for emacs deliver. example.com
seems a sensible address to use. This is short enough that we don't
get the line breaks above and the tests then all pass.
---

I don't know when this test started failing: I tried to bisect and it
went back quite a long way on machines which I thought had been
passing the tests. (It does look like things outside notmuch might
make some differences though so maybe this is not surprising)

Best wishes

Mark


 test/test-lib.sh |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/test/test-lib.sh b/test/test-lib.sh
index d3a8c58..2aa4dfc 100644
--- a/test/test-lib.sh
+++ b/test/test-lib.sh
@@ -445,6 +445,7 @@ emacs_deliver_message ()
 
     test_emacs \
 	"(let ((message-send-mail-function 'message-smtpmail-send-it)
+               (mail-host-address \"example.com\")
 	       (smtpmail-smtp-server \"localhost\")
 	       (smtpmail-smtp-service \"25025\"))
 	   (notmuch-hello)
-- 
1.7.9.1

Re: [PATCH] test: set mail host in emacs_deliver

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> One test (reply to encrypted message in the crypto test) recently
> started failing on some systems. The failure I saw were two extra
> lines of the form
> <87d2nbc5xg.fsf@host.i-did-not-set--mail-host-address--so-tickle-me>
>

pushed, thanks. Now I can rebuild notmuch on my office machine again.

d