From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 184C0431FBD for ; Mon, 10 Mar 2014 16:14:18 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q6dhW3lVmdY6 for ; Mon, 10 Mar 2014 16:14:14 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 897C9431FBC for ; Mon, 10 Mar 2014 16:14:14 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1WN9Oa-0004qK-Sp; Mon, 10 Mar 2014 20:14:08 -0300 Received: (nullmailer pid 15999 invoked by uid 1000); Mon, 10 Mar 2014 23:14:05 -0000 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v4 08/13] test: add database upgrade test from format version 1 to 2 In-Reply-To: References: User-Agent: Notmuch/0.17+120~gccab40f (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 10 Mar 2014 20:14:05 -0300 Message-ID: <87siqp7iki.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Mar 2014 23:14:18 -0000 Jani Nikula writes: > Test the upgrade from probabilistic to boolean folder: terms, and > addition of path: terms. > > The test depends on the pre-built test corpus and database tarball and > checksum file being in place. If it's not, the test is skipped. The > mechanism to fetch the test database will be added later. > > At the time of writing, a working test database and checksum file is > available at > > http://notmuchmail.org/releases/test-databases/ > Hi Jani; This test has gotten out of sync with the corpus in the tree. It still passes because the database tarball on notmuchmail.org is in the previous (multi-corpus) style. In particular % cd test % ../devel/gen-testdb.sh -s v1 -v 0.17 % sed -i s/folders-v1/database-v1/ T530-upgrade.sh % ./T530-upgrade yields several failures. I think it would be better to update the test to match corpus currently in the tree. d