unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 08/13] test: add database upgrade test from format version 1 to 2
Date: Mon, 10 Mar 2014 20:14:05 -0300	[thread overview]
Message-ID: <87siqp7iki.fsf@zancas.localnet> (raw)
In-Reply-To: <c7812c1dac1014868d80745305272322d2d25d9a.1394400503.git.jani@nikula.org>

Jani Nikula <jani@nikula.org> writes:

> Test the upgrade from probabilistic to boolean folder: terms, and
> addition of path: terms.
>
> The test depends on the pre-built test corpus and database tarball and
> checksum file being in place. If it's not, the test is skipped. The
> mechanism to fetch the test database will be added later.
>
> At the time of writing, a working test database and checksum file is
> available at
>
>    http://notmuchmail.org/releases/test-databases/
>

Hi Jani;

This test has gotten out of sync with the corpus in the tree. It still
passes because the database tarball on notmuchmail.org is in the
previous (multi-corpus) style. In particular

% cd test
% ../devel/gen-testdb.sh -s v1 -v 0.17
% sed -i s/folders-v1/database-v1/ T530-upgrade.sh 
% ./T530-upgrade

yields several failures.

I think it would be better to update the test to match corpus currently
in the tree.

d

  reply	other threads:[~2014-03-10 23:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-09 21:40 [PATCH v4 00/13] boolean folder: and path: searches Jani Nikula
2014-03-09 21:40 ` [PATCH v4 01/13] test: rearrange the test corpus into subfolders Jani Nikula
2014-03-09 21:40 ` [PATCH v4 02/13] test: add notmuch_search_files_sanitize and use it Jani Nikula
2014-03-09 21:40 ` [PATCH v4 03/13] lib: refactor folder term update after filename removal Jani Nikula
2014-03-09 21:40 ` [PATCH v4 04/13] lib: add support for path: prefix searches Jani Nikula
2014-03-09 21:40 ` [PATCH v4 05/13] test: make insert test use the path: prefix Jani Nikula
2014-03-09 21:40 ` [PATCH v4 06/13] lib: make folder: prefix literal Jani Nikula
2014-03-09 21:40 ` [PATCH v4 07/13] test: add tests for the new boolean folder: and path: prefixes Jani Nikula
2014-03-09 21:40 ` [PATCH v4 08/13] test: add database upgrade test from format version 1 to 2 Jani Nikula
2014-03-10 23:14   ` David Bremner [this message]
2014-03-11  5:42     ` [PATCH v5] " Jani Nikula
2014-03-09 21:40 ` [PATCH v4 09/13] man: update man pages for folder: and path: search terms Jani Nikula
2014-03-10  6:25   ` [PATCH v5] " Jani Nikula
2014-03-09 21:40 ` [PATCH v4 10/13] man: try to clarify the folder: and path: vs. --output=files confusion Jani Nikula
2014-03-10  6:26   ` [PATCH v5] " Jani Nikula
2014-03-09 21:40 ` [PATCH v4 11/13] devel: add script to generate test databases Jani Nikula
2014-03-09 21:40 ` [PATCH v4 12/13] test: commit folders-v1.tar.xz checksum, ignore actual databases Jani Nikula
2014-03-09 21:40 ` [PATCH v4 13/13] test: add machinery to download and verify databases Jani Nikula
2014-03-10  6:24   ` [PATCH v5] " Jani Nikula
2014-03-10 18:28 ` [PATCH v4 00/13] boolean folder: and path: searches Austin Clements
2014-03-10 21:57 ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87siqp7iki.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).