From: Jani Nikula <jani@nikula.org>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 03/13] new: Don't report version after upgrade
Date: Sat, 23 Aug 2014 18:39:09 +0300 [thread overview]
Message-ID: <87siknjjvm.fsf@nikula.org> (raw)
In-Reply-To: <1406859003-11561-4-git-send-email-amdragon@mit.edu>
On Fri, 01 Aug 2014, Austin Clements <amdragon@MIT.EDU> wrote:
> The version number has always been pretty meaningless to the user and
> it's about to become even more meaningless with the introduction of
> "features". Hopefully, the database will remain on version 3 for some
> time to come; however, the introduction of new features over time in
> version 3 will necessitate upgrades within version 3. It would be
> confusing if we always tell the user they've been "upgraded to version
> 3". If the user wants to know what's new, they should read the news.
I think this is good for now.
What do you think about adding notmuch_database_get_features(), and
printing that?
BR,
Jani.
> ---
> notmuch-new.c | 3 +--
> test/T530-upgrade.sh | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/notmuch-new.c b/notmuch-new.c
> index d269c7c..b7590a8 100644
> --- a/notmuch-new.c
> +++ b/notmuch-new.c
> @@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])
> add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,
> &add_files_state);
> if (add_files_state.verbosity >= VERBOSITY_NORMAL)
> - printf ("Your notmuch database has now been upgraded to database format version %u.\n",
> - notmuch_database_get_version (notmuch));
> + printf ("Your notmuch database has now been upgraded.\n");
> }
>
> add_files_state.total_files = 0;
> diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh
> index 7d5d5aa..c4c4ac8 100755
> --- a/test/T530-upgrade.sh
> +++ b/test/T530-upgrade.sh
> @@ -33,7 +33,7 @@ test_expect_equal "$output" "\
> Welcome to a new version of notmuch! Your database will now be upgraded.
> This process is safe to interrupt.
> Backing up tags to FILENAME
> -Your notmuch database has now been upgraded to database format version 2.
> +Your notmuch database has now been upgraded.
> No new mail."
>
> test_begin_subtest "tag backup matches pre-upgrade dump"
> --
> 2.0.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-08-23 15:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 2:09 [PATCH v3 00/13] Implement and use database "features" Austin Clements
2014-08-01 2:09 ` [PATCH v3 01/13] test: Include generated dependencies for test sources Austin Clements
2014-08-01 2:09 ` [PATCH v3 02/13] util: Const version of strtok_len Austin Clements
2014-08-06 13:43 ` David Bremner
2014-08-01 2:09 ` [PATCH v3 03/13] new: Don't report version after upgrade Austin Clements
2014-08-23 15:39 ` Jani Nikula [this message]
2014-08-23 22:59 ` Austin Clements
2014-08-24 12:56 ` Jani Nikula
2014-08-01 2:09 ` [PATCH v3 04/13] lib: Database version 3: Introduce fine-grained "features" Austin Clements
2014-08-23 16:02 ` Jani Nikula
2014-08-24 0:57 ` Austin Clements
2014-08-23 22:21 ` David Bremner
2014-08-24 0:58 ` Austin Clements
2014-08-24 3:58 ` David Bremner
2014-08-24 22:16 ` Austin Clements
2014-08-24 23:03 ` David Bremner
2014-08-01 2:09 ` [PATCH v3 05/13] test: Tool to build DB with specific version and features Austin Clements
2014-08-23 16:03 ` Jani Nikula
2014-08-01 2:09 ` [PATCH v3 06/13] test: Tests for future version and unknown feature handling Austin Clements
2014-08-01 2:09 ` [PATCH v3 07/13] lib: Simplify upgrade code using a transaction Austin Clements
2014-08-01 2:09 ` [PATCH v3 08/13] lib: Use database features to drive upgrade Austin Clements
2014-08-01 2:09 ` [PATCH v3 09/13] lib: Reorganize upgrade around document types Austin Clements
2014-08-01 2:10 ` [PATCH v3 10/13] lib: Report progress for combined upgrade operation Austin Clements
2014-08-01 2:10 ` [PATCH v3 11/13] lib: Support empty header values in database Austin Clements
2014-08-01 2:10 ` [PATCH v3 12/13] lib: Return an error from operations that require an upgrade Austin Clements
2014-08-01 2:10 ` [PATCH v3 13/13] lib: Update doc of notmuch_database_{needs_upgrade, upgrade} Austin Clements
2014-08-07 21:55 ` [PATCH v3 00/13] Implement and use database "features" Tomi Ollila
2014-08-08 18:18 ` Austin Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siknjjvm.fsf@nikula.org \
--to=jani@nikula.org \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).