From: David Bremner <david@tethera.net>
To: David Binderman <dcb314@hotmail.com>,
"notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: RE: notmuch-0.21 bug report
Date: Mon, 25 Apr 2016 16:40:07 -0300 [thread overview]
Message-ID: <87shy9bhpk.fsf@zancas.localnet> (raw)
In-Reply-To: <DUB128-W40FF39685EC08E151E7E5B9C620@phx.gbl>
David Binderman <dcb314@hotmail.com> writes:
> Hello there,
>
> ----------------------------------------
>> Hi David;
>>
>> Thanks for the report. fclose doesn't really make sense here;
>
> Surprising. There is a call to fclose for the success return,
> so I just assumed that one would also be required for the error return.
>
Ah OK, I thought the fclose referred to the notmuch database, but it
refers to the input file. So yes, there is techically a resource leakage
here, but I'm not sure how important it is, since these returns are part
of program shutdown. Is there any harm in having FILEs open for read
when a program shuts down? On the other hand, I guess it would only take
5 or 6 added lines of code if someone wanted to add our usual "goto
DONE" path
d
prev parent reply other threads:[~2016-04-25 19:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-25 16:00 notmuch-0.21 bug report David Binderman
2016-04-25 18:16 ` David Bremner
2016-04-25 18:26 ` David Binderman
2016-04-25 19:40 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shy9bhpk.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=dcb314@hotmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).