From: David Bremner <david@tethera.net>
To: Steven Allen <steven@stebalien.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: use define-derived-mode for defining modes.
Date: Fri, 09 Sep 2016 21:38:03 -0300 [thread overview]
Message-ID: <87sht81tec.fsf@zancas.localnet> (raw)
In-Reply-To: <20160828184122.26002-1-steven@stebalien.com>
Steven Allen <steven@stebalien.com> writes:
> This sets up and runs all the correct hooks and reduces some redundancy.
> ---
> emacs/notmuch-hello.el | 8 +-------
> emacs/notmuch-show.el | 7 +------
> emacs/notmuch-tree.el | 7 +------
> emacs/notmuch.el | 7 +------
> 4 files changed, 4 insertions(+), 25 deletions(-)
>
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index 75ccf57..d582bff 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -671,7 +671,7 @@ with `notmuch-hello-query-counts'."
> "Keymap for \"notmuch hello\" buffers.")
> (fset 'notmuch-hello-mode-map notmuch-hello-mode-map)
>
> -(defun notmuch-hello-mode ()
> +(define-derived-mode notmuch-hello-mode fundamental-mode "notmuch-hello"
> "Major mode for convenient notmuch navigation. This is your entry portal into notmuch.
The idea seems sane, but shouldn't we derive from special-mode?
d
next prev parent reply other threads:[~2016-09-10 0:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-28 18:41 [PATCH] emacs: use define-derived-mode for defining modes Steven Allen
2016-09-01 14:57 ` Tomi Ollila
2016-09-10 0:38 ` David Bremner [this message]
2016-09-10 1:31 ` Steven Allen
2016-09-10 8:08 ` Tomi Ollila
2016-09-10 16:10 ` David Bremner
2016-09-10 16:19 ` Steven Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sht81tec.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=steven@stebalien.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).