From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 739536DE0941
 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2016 03:43:44 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.006
X-Spam-Level: 
X-Spam-Status: No, score=-0.006 tagged_above=-999 required=5 tests=[AWL=0.005, 
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id RvCQfuMGuuo9 for <notmuch@notmuchmail.org>;
 Wed, 16 Nov 2016 03:43:43 -0800 (PST)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 8A8D56DE0222
 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2016 03:43:43 -0800 (PST)
Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2)
 (envelope-from <david@tethera.net>)
 id 1c6ycZ-0007aG-IX; Wed, 16 Nov 2016 06:43:19 -0500
Received: (nullmailer pid 15782 invoked by uid 1000);
 Wed, 16 Nov 2016 11:43:37 -0000
From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, Paul Wise <pabs@debian.org>,
 notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: consider files vanishing during notmuch new
 non-fatal
In-Reply-To: <1478350621-17137-1-git-send-email-jani@nikula.org>
References: <1478312104.1979.8.camel@debian.org>
 <1478350621-17137-1-git-send-email-jani@nikula.org>
Date: Wed, 16 Nov 2016 07:43:37 -0400
Message-ID: <87shqrwsye.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Nov 2016 11:43:44 -0000

Jani Nikula <jani@nikula.org> writes:

> +/* Exit status code indicating that file(s) in the mail store were
> + * removed or renamed after notmuch new scanned the directories but
> + * before indexing the file(s). If the file was renamed, the indexing
> + * might not be complete, and the user is advised to re-run notmuch
> + * new.
> + */
> +#define NOTMUCH_EXIT_VANISHED_FILES 10
> +

What do you think about defining something like NOTMUCH_EXIT_TEMPFAIL 75
(to match EX_TEMPFAIL) and using that?  There is also some stalled patch
around for insert to use EX_TEMPFAIL (although in that case part of the
reason it has stalled is I'm not convinced the error is temporary).

I think such an exit code would also make sense for locking failures;
but that is a different discussion.

Other than that the patch looks like an incremental improvement