From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id BCAB26DE29E1 for ; Fri, 14 Jul 2017 06:26:59 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.000] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ai7P2y6WF9Rc for ; Fri, 14 Jul 2017 06:26:59 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id 10D466DE0C19 for ; Fri, 14 Jul 2017 06:26:59 -0700 (PDT) Received: from fifthhorseman.net (38.200.broadband6.iol.cz [88.101.200.38]) by che.mayfirst.org (Postfix) with ESMTPSA id 9F537F999 for ; Fri, 14 Jul 2017 09:26:57 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 878E720302; Fri, 14 Jul 2017 15:26:54 +0200 (CEST) From: Daniel Kahn Gillmor To: Notmuch Mail Subject: Re: [PATCH 2/2] Add additional munged reply-to tests In-Reply-To: <20170714130912.24777-2-dkg@fifthhorseman.net> References: <20170714130912.24777-1-dkg@fifthhorseman.net> <20170714130912.24777-2-dkg@fifthhorseman.net> Date: Fri, 14 Jul 2017 15:26:51 +0200 Message-ID: <87shhz6tes.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 13:26:59 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Fri 2017-07-14 15:09:12 +0200, Daniel Kahn Gillmor wrote: > The reply-to munging code might behave differently whether there's an > exact match on the strings or not, or whether the string is a raw > addr-spec instead of an name-addr. These tests cover those > variations. This pair of patches should be safe and clean to apply. When they're applied, though, the gmime 3.0 series no longer passes the test suite due to these failures: =2D--------- T220-reply: Testing "notmuch reply" in several variations PASS Basic reply PASS Multiple recipients PASS Reply with CC PASS Reply from alternate address PASS Reply from address in named group list PASS Support for Reply-To FAIL Un-munging Reply-To --- T220-reply.7.expected 2017-07-14 13:24:32.203184911 +0000 +++ T220-reply.7.output 2017-07-14 13:24:32.203184911 +0000 @@ -6,3 +6,4 @@ =09=20 On Tue, 05 Jan 2010 15:43:56 -0000, Sender wrote: > Un-munging Reply-To +failed FAIL Un-munging Reply-To With Exact Match --- T220-reply.8.expected 2017-07-14 13:24:32.243185095 +0000 +++ T220-reply.8.output 2017-07-14 13:24:32.243185095 +0000 @@ -6,3 +6,4 @@ =09=20 On Tue, 05 Jan 2010 15:43:56 -0000, Sender wrote: > Un-munging Reply-To +failed PASS Un-munging Reply-To With Raw addr-spec PASS Message with header of exactly 200 bytes PASS From guessing: Envelope-To PASS From guessing: X-Original-To PASS From guessing: Delivered-To PASS Reply with RFC 2047-encoded headers PASS Reply with RFC 2047-encoded headers (JSON) PASS Reply to a message with multiple Cc headers =2D--------- I think this is due to "notmuch reply" crashing on those first two tests with a segmentation fault. i think this implicates the reply-to munging code, which i don't understand, but would welcome help on debugging. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEOCdgUepHf6PklTkyFJitxsGSMjcFAlloxpsACgkQFJitxsGS MjfdahAAmuqpSUUNQNTvTZ9hF1cCHvWCHeqLqLYsuagx4BXrLAQwIqkHiWO6jGMX 12DaVqMHlli3T6ABKDNcr33d6RAgEM+pBZcEkbbK9vjmzX0NITkK2nFm6+Jj9R+R gDXCR7xqDuvcImDGD8iuXHto8pVGXhV1aVayskz5BeO9CrOpz4DSqB9892sl9F6A VfuE4b0eC48H2Ahy8Ora0j7ieKgCb0m23us6MVe0ON3Mb8pxaA/soh8X+DYbz/5S PNYnmy/UNB6ymUFmJJR/xsI5G9DWWHCE3sZGkPD6mgxAqVsl2NDRLOzEkGGLVyyu 3pzxJKcE5aCPFPdHibWMmVjW/XBrkBmoRy+NJVz1wNT/KQX4hWpbOZ+BhRIyAwgn OiGJZkr1Dg8Kj25zbcyZ/BCQE7DjluGgZALR0jWvkwSLVGRGS7K6JIEBRDVfdKp3 z4Zy6h8Q81qCAutdPxdrFu67Ppx5SpexV+t3mdWpPSFaxxA9U/jFRDjfdK+LSJiD wFPPyY31CPrnEJn1Cz/rjyD4nKlrWhsZ8DBfJorTY8PaoLr0KwqmyhlQwdSPrLr+ J1cxik+RUD9N2/MjtZAyK7Uj8x8OmyybeT9AJWk2IaD/V+wyuDnD+1wFOBZgHzVX ZscNxepRBjoDv9YjE9wzIVvTT7jwICrD6W5roiIReLEeCcXUrKk= =fFW2 -----END PGP SIGNATURE----- --=-=-=--