From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id D64FA6DE12DD for ; Mon, 3 Jun 2019 02:18:55 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -2.696 X-Spam-Level: X-Spam-Status: No, score=-2.696 tagged_above=-999 required=5 tests=[AWL=-0.194, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EGn2VecDrsFE for ; Mon, 3 Jun 2019 02:18:54 -0700 (PDT) Received: from smtp-4.sys.kth.se (smtp-4.sys.kth.se [130.237.48.193]) by arlo.cworth.org (Postfix) with ESMTPS id 76A706DE12D6 for ; Mon, 3 Jun 2019 02:18:54 -0700 (PDT) Received: from smtp-4.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-4.sys.kth.se (Postfix) with ESMTP id 9670A2855; Mon, 3 Jun 2019 11:18:52 +0200 (CEST) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-4.sys.kth.se ([127.0.0.1]) by smtp-4.sys.kth.se (smtp-4.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 2JVFqpy2pen5; Mon, 3 Jun 2019 11:18:52 +0200 (CEST) X-KTH-Auth: ekeberg [85.229.204.229] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1559553531; bh=I1/ed4RUyRvlhzJl6LbbGsrAvD76FfXdm/hJ7VVdRek=; h=From:To:Subject:In-Reply-To:References:Date; b=KMM7WkrYLGVDhkwbuT6yXWLvI8NkqixCjr//wgfuQRvY2K/DHQVdbh8z3K4oPlequ xIsAmohORhuVP2lmSgLsNy1qS0ta01QWUDmV0kZd62iTA2ZApuzwIjsy9ehos2v5eb o4SobvGgegzQsr+yc2GfqoMMy6i8ux32TyTjRb+c= X-KTH-mail-from: ekeberg@kth.se Received: from swing (c-e5cce555.09-723-73746f39.bbcust.telenor.se [85.229.204.229]) by smtp-4.sys.kth.se (Postfix) with ESMTPSA id 1A13D48B; Mon, 3 Jun 2019 11:18:51 +0200 (CEST) From: =?utf-8?Q?=C3=96rjan?= Ekeberg To: David Bremner , notmuch@notmuchmail.org Subject: Re: notmuch-message-mark-replied In-Reply-To: <87r28e40m6.fsf@tethera.net> References: <87r28e40m6.fsf@tethera.net> Date: Mon, 03 Jun 2019 11:18:50 +0200 Message-ID: <87sgsrt4at.fsf@swing.csc.kth.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jun 2019 09:18:56 -0000 David Bremner writes: > In d9800c8 we deleted the function notmuch-message-mark-replied. > > Should we make a deprecated-alias for > notmuch-message-apply-queued-tag-changes? The two functions are not interchangeable, so it may not be appropriate to mark it as an alias. notmuch-message-mark-replied looked for a In-Reply-To: header while notmuch-message-apply-queued-tag-changes checks if the message has notmuch-message-queued-tag-changes set (it is set when composing a reply). On the other hand; if a user has code which explicitly sets the message-send-hook, the new function will serve as the natural replacement for the deleted one. /=C3=96rjan