notmuch-message-mark-replied

notmuch-message-mark-replied

[David Bremner]

In  d9800c8 we deleted the function notmuch-message-mark-replied.

Should we make a deprecated-alias for
notmuch-message-apply-queued-tag-changes?

d

Re: notmuch-message-mark-replied

[Örjan Ekeberg]

David Bremner <david@tethera.net> writes:
> In  d9800c8 we deleted the function notmuch-message-mark-replied.
>
> Should we make a deprecated-alias for
> notmuch-message-apply-queued-tag-changes?

The two functions are not interchangeable, so it may not be appropriate
to mark it as an alias.

notmuch-message-mark-replied looked for a In-Reply-To: header while
notmuch-message-apply-queued-tag-changes checks if the message has
notmuch-message-queued-tag-changes set (it is set when composing a reply).

On the other hand; if a user has code which explicitly sets the
message-send-hook, the new function will serve as the natural
replacement for the deleted one.

/Örjan

Re: notmuch-message-mark-replied

[David Bremner]

Örjan Ekeberg <ekeberg@kth.se> writes:

> David Bremner <david@tethera.net> writes:
>> In  d9800c8 we deleted the function notmuch-message-mark-replied.
>>
>> Should we make a deprecated-alias for
>> notmuch-message-apply-queued-tag-changes?
>
> The two functions are not interchangeable, so it may not be appropriate
> to mark it as an alias.
[snip]
> On the other hand; if a user has code which explicitly sets the
> message-send-hook, the new function will serve as the natural
> replacement for the deleted one.

So maybe just a NEWS snippet to point those users in the right
direction?

d

Re: notmuch-message-mark-replied

[Rollins, Jameson]

On Mon, Jun 03 2019, David Bremner <david@tethera.net> wrote:
> Örjan Ekeberg <ekeberg@kth.se> writes:
>
>> David Bremner <david@tethera.net> writes:
>>> In  d9800c8 we deleted the function notmuch-message-mark-replied.
>>>
>>> Should we make a deprecated-alias for
>>> notmuch-message-apply-queued-tag-changes?
>>
>> The two functions are not interchangeable, so it may not be appropriate
>> to mark it as an alias.
> [snip]
>> On the other hand; if a user has code which explicitly sets the
>> message-send-hook, the new function will serve as the natural
>> replacement for the deleted one.
>
> So maybe just a NEWS snippet to point those users in the right
> direction?

I have the following in my emacs config:

 '(message-send-hook
   (quote
    (notmuch-message-mark-replied notmuch-fcc-header-setup)))

I'm wondering what if anything I should replace this with.

jamie.

Re: notmuch-message-mark-replied

[David Bremner]

"Rollins, Jameson" <jrollins@caltech.edu> writes:

> I have the following in my emacs config:
>
>  '(message-send-hook
>    (quote
>     (notmuch-message-mark-replied notmuch-fcc-header-setup)))

As far as I know it can be deleted. At least both marking as replied and
fcc headers work OK for me without it.

d

Re: notmuch-message-mark-replied

[Örjan Ekeberg]

"Rollins, Jameson" <jrollins@caltech.edu> writes:
> I have the following in my emacs config:
>
>  '(message-send-hook
>    (quote
>     (notmuch-message-mark-replied notmuch-fcc-header-setup)))
>
> I'm wondering what if anything I should replace this with.

You should probably remove this altogether.

notmuch-message-mark-replied used to be the default value for this hook,
but has now been replaced by notmuch-message-apply-queued-tag-changes.

notmuch-fcc-header-setup is called already when composing a message, so
it no longer is needed to call is from the hook.

/Örjan

Re: notmuch-message-mark-replied

[Rollins, Jameson]

On Mon, Jun 03 2019, Örjan Ekeberg <ekeberg@kth.se> wrote:
> "Rollins, Jameson" <jrollins@caltech.edu> writes:
>> I have the following in my emacs config:
>>
>>  '(message-send-hook
>>    (quote
>>     (notmuch-message-mark-replied notmuch-fcc-header-setup)))
>>
>> I'm wondering what if anything I should replace this with.
>
> You should probably remove this altogether.
>
> notmuch-message-mark-replied used to be the default value for this hook,
> but has now been replaced by notmuch-message-apply-queued-tag-changes.
>
> notmuch-fcc-header-setup is called already when composing a message, so
> it no longer is needed to call is from the hook.

Great thanks.