From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: STYLE and uncrustify
Date: Fri, 07 Jun 2019 07:58:24 -0300 [thread overview]
Message-ID: <87sgslmzlb.fsf@tethera.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 880 bytes --]
I'm pondering running uncrustify on all/most of the notmuch codebase,
but I noticed a few things that uncrustify does are either not
documented in STYLE, or maybe contradicted.
1) Should block comments start with '*' ? Uncrustify thinks yes, STYLE
is silent, the codebase says mostly yes. I think update STYLE to
match uncrustify here.
2) Should there be a space after '!'? Uncrustify says yes, STYLE is
silent, the codebase is inconsistent. Updating STYLE would be the
easy thing here, but I remember previous discussions being
inconclusive.
3) Similar for space between '++' and '--' and operand
4) uncrustify wants to move 'const char* foo' to 'const char *foo'.
That's about all I have patience for at the moment.
When I say 'uncrustify', I really mean 'our current uncrustify
config'. I don't know offhand how hard any of these items are to change.
d
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 658 bytes --]
next reply other threads:[~2019-06-07 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 10:58 David Bremner [this message]
2019-06-09 19:40 ` STYLE and uncrustify Daniel Kahn Gillmor
2019-06-11 19:54 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgslmzlb.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).