From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wOiYCSSIjmBKuwAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 13:08:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id QPgmBSSIjmDcSwAAbx9fmQ (envelope-from ) for ; Sun, 02 May 2021 11:08:20 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D47792C7BF for ; Sun, 2 May 2021 13:08:19 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id EE2A9271D4; Sun, 2 May 2021 07:08:17 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id D6A9520017 for ; Sun, 2 May 2021 07:08:14 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id CDC1360016; Sun, 2 May 2021 07:08:14 -0400 (EDT) Received: (nullmailer pid 871756 invoked by uid 1000); Sun, 02 May 2021 11:08:13 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 8/9] test: ruby: don't use instance variables In-Reply-To: <20210501115923.483816-9-felipe.contreras@gmail.com> References: <20210501115923.483816-1-felipe.contreras@gmail.com> <20210501115923.483816-9-felipe.contreras@gmail.com> Date: Sun, 02 May 2021 08:08:13 -0300 Message-ID: <87sg35mm02.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: VHUUL7H5GOGVDB6TMDFQAB5Z3A2BSWIT X-Message-ID-Hash: VHUUL7H5GOGVDB6TMDFQAB5Z3A2BSWIT X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619953699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=7dIEBZ+I8Pq6RyyIIgyJOqbCzbAZNW68rzSF5qtePkc=; b=ZRD5TsGhEEc7oimYMqyeC52Z1/0g7fq44m4s/buByJ1Xp7YXCE8SdPJLhTfJ4Em8KuCfEj suCLSK4KyWnjTz5R00qEUKf+RWWzox6jsimGihyZZfYsYplBZ1k9g6WgPJOw8Xae7Yrum2 EQOQ91tMCuF86GGUkswm0XB4FNK/XfxRe9aYXaFxxEcYZhc4vbx8jY2aM1b7HGPNe0bXZM uEvpqdNRepkM6EjRf1MrTsHtJXgshZDLUEWneh/0JodKVOIgR+b6Np8PDu5S+vI7MOYjMR wTrG6O2U0sZjPn41dDLX7dNZTDMQJEA2vQJ4ahjWlGp2XdrYFrgTR4enVqwnsw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619953699; a=rsa-sha256; cv=none; b=pAy7qNpmyDSAHhjrO4cuIO4Q00EeH/m7TJyxn63Xk9qV2iQ1sRi6nBsZsxb+Ma0xe/vl5A +kpc9QH6GJz/G1OTsS7uovbOIU9s2Xnk1A5pVOqssF0edE7w6nzVYatKXs64mLz4wtsSTS lAivtPKgW6NprWg9sPbOWSCCWqD04z6LgZ5HaMUATQdHOwPmgESL00Kqzh8Mbl317wJX1B hWE2PDRV/iNkkMbVMy0yP0wkHkeoleh1KFjsXQTuFW7sO4NEb9nfj8EIyPZfRgFzTalgmg kNCpeVQfDW9tKx7o19IRJkj158En2MNY3POcSIKgG8NM2j+UBSKIkoAeYBqEhg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.07 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D47792C7BF X-Spam-Score: -2.07 X-Migadu-Scanner: scn0.migadu.com X-TUID: LlNmu+qup1La Felipe Contreras writes: > Local variables are perfectly fine. > LGTM (given it works)