From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4] test: replace notmuch_passwd_sanitize() with _libconfig_sanitize()
Date: Sat, 22 May 2021 08:56:18 -0300 [thread overview]
Message-ID: <87sg2ft21p.fsf@tethera.net> (raw)
In-Reply-To: <20210520134628.11653-1-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> cat <<EOF > c_head
> #include <string.h>
> #include <stdlib.h>
> @@ -380,26 +399,26 @@ cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} '' %NULL%
> key < NOTMUCH_CONFIG_LAST;
> key = (notmuch_config_key_t)(key + 1)) {
> const char *val = notmuch_config_get (db, key);
> - printf("%s\n", val ? val : "NULL" );
> + printf("%x: '%s'\n", key, val ? val : "NULL" );
> }
> }
> EOF
It seems not that unlikely that we will hit 16 configuration keys. Would
it be better to use 2 digits 0 padded (and in that case we could
probably stick to decimal). Or maybe having different number of digits
for later keys does not matter?
d
prev parent reply other threads:[~2021-05-22 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 13:46 [PATCH v4] test: replace notmuch_passwd_sanitize() with _libconfig_sanitize() Tomi Ollila
2021-05-22 11:56 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg2ft21p.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).