unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Alan Schmitt <alan.schmitt@polytechnique.org>
To: notmuch <notmuch@notmuchmail.org>
Subject: Re: notmuch-tag failing on trailing space
Date: Mon, 16 Aug 2021 11:03:35 +0200	[thread overview]
Message-ID: <87sfz9iwwo.fsf@m4x.org> (raw)
In-Reply-To: <87im0w6u5r.fsf@m4x.org>


[-- Attachment #1.1: Type: text/plain, Size: 760 bytes --]

Hello,

On 2021-07-27 10:24, alan.schmitt@polytechnique.org writes:

> I have an issue when using the vertico completion system to add tags to
> messages that boils down to the following: the notmuch-tag function is
> called like this:
>   notmuch-tag("id:CA+b3G33ad9PX5SuOwqaWS8TWBTtZcdguKtcQ3XmPvzSCsU..." ("+cwn "))
> and it fails because of the extra space at the end.
>
> Could notmuch-tag be modified to accept trailing spaces?

Someone on the doom discord suggested the following workaround.

#+begin_src emacs-lisp
  (defun trim-tag-changes (args)
    (list (car args) (mapcar #'s-trim-right (cadr args))))
  (advice-add 'notmuch-tag :filter-args #'trim-tag-changes)
#+end_src

Could it be integrated directly in the notmuch-tag function?

Best,

Alan

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 528 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  parent reply	other threads:[~2021-08-16  9:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27  8:24 notmuch-tag failing on trailing space alan.schmitt
2021-07-27  9:37 ` Tomi Ollila
2021-08-16  9:03 ` Alan Schmitt [this message]
2021-08-16 15:17   ` David Bremner
2021-08-16 15:48     ` David Edmondson
2021-08-17  5:52       ` Tomi Ollila
2021-10-23 17:05         ` [PATCH] emacs: don't add space to tag completion candidates David Bremner
2021-10-29 15:30           ` inwit
2021-10-30  9:31             ` David Bremner
2021-10-31 19:34               ` Tomi Ollila
2021-12-04 16:59           ` David Bremner
2021-08-16 15:52     ` notmuch-tag failing on trailing space Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfz9iwwo.fsf@m4x.org \
    --to=alan.schmitt@polytechnique.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).