From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mJUFDmaZV2Q7rwAASxT56A (envelope-from ) for ; Sun, 07 May 2023 14:28:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eFXfDGaZV2TzeQAAG6o9tA (envelope-from ) for ; Sun, 07 May 2023 14:28:22 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 143C93A0B1 for ; Sun, 7 May 2023 14:28:21 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1F80D5E016; Sun, 7 May 2023 12:28:18 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [192.99.9.157]) by mail.notmuchmail.org (Postfix) with ESMTPS id C195A5DD5A for ; Sun, 7 May 2023 12:28:15 +0000 (UTC) Received: from tethera.net (unknown [75.104.166.118]) by phubs.tethera.net (Postfix) with ESMTPS id 26C81180050; Sun, 7 May 2023 09:28:10 -0300 (ADT) Received: (nullmailer pid 204392 invoked by uid 1000); Sun, 07 May 2023 12:27:57 -0000 From: David Bremner To: Mohsin Kaleem , notmuch@notmuchmail.org Subject: Re: [PATCH v2 1/3] emacs: Add new option notmuch-search-hide-excluded In-Reply-To: <87o7mzrok9.fsf@kisara.moe> References: <87v8re66mg.fsf@tethera.net> <20230416131811.658253-1-mohkale@kisara.moe> <20230416131811.658253-2-mohkale@kisara.moe> <87y1m5dw49.fsf@tethera.net> <87o7mzrok9.fsf@kisara.moe> Date: Sun, 07 May 2023 06:27:57 -0600 Message-ID: <87sfc8pbqq.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: BQT2TMTWJR2WTUOXGOGIMVB7UORZWKD4 X-Message-ID-Hash: BQT2TMTWJR2WTUOXGOGIMVB7UORZWKD4 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683462502; a=rsa-sha256; cv=none; b=fBaNU6W6P4XkU5CmcDCsEnTVVTj8tfxQoTCY2qkab6k7u7Li9zgcUBZOnPsUzGwIgd7tIm m9gkRX1N/9uB1oUrngOX43ls+qP+aeZJ5yJM3IfpveFl9srEQreACKdykBlAkHnq4jOzoN NAUf7qaYohpHO1bCQlDiqByjrAx6bJKyxtWHj3NaDAIfy8h6e4Da08R+6iXQCf5JEES42q 3eZNRuvznyFMcib8gavS3VLL0QEbipa1AOdYpsaT8cADV5Qj4ciGRkQKeZonMcM583zhD4 L3me+SEjhyxQssLhGak6XS3fEjf+d8pg823Ho3ZQvv5G3Y9WWTk4KwpxRmSHIQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683462502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=SZCiVpVAtyjqdRFbUghicXoe/OSxnOIvuMyvVp3iWd4=; b=KN97vkbQAB5713lbhRvMTL0jpe+IKDR6BA4m12kGh5IRII/bVVrh7sIkbV3/JGVI065aVU xHfGpG1fLuNKz7WZEoSgx2urifS57jXr+XI4AxUoamnuyTBuxRB077/83HnPptCmia9aX8 j6S/YFV2JSOcVBc47i7NLVVtvjwPWEvBvChFXdT1BOY84eBnAdL+ePwYaOLaAgncWsq/kk OH+wW05zcMrTBQ8Ki9gyKszoUPKR97+N6pxW3qh1C6dyrNr/1O+PCtsh8t26UNn8IKXXOp /empaDjdNUUo2OqLlsJDUuksu4QoAyXhOGmK5Brv/uVFmVQb9cpJ0krzIPnm8w== X-Migadu-Spam-Score: -1.87 X-Spam-Score: -1.87 X-Migadu-Queue-Id: 143C93A0B1 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-TUID: gW8p+DCvckho Mohsin Kaleem writes: > We could workaround this by changing the semantics of the variable. Make > it notmuch-search-show-excluded and default to nil so nothing has to be > changed in existing functions that call notmuch-search. Or we could > switch to using cl-defun and have the default value substituted in the > parameter list. I've never used cl-defun with interactive functions but > long term I think that's the saner solution. Thanks for the explanation. I think we can live with it as is for now, and look into the cl-defun "upgrade" later. I suspect it will be a bit confusing if we invert the sense of the variable relative to the CLI argument. d