* [PATCH -v3] notmuch.el: Add face support to search and show mode
@ 2009-11-23 5:21 Aneesh Kumar K.V
2009-11-26 20:56 ` Carl Worth
0 siblings, 1 reply; 2+ messages in thread
From: Aneesh Kumar K.V @ 2009-11-23 5:21 UTC (permalink / raw)
To: notmuch
This add two faces, notmuch-show-subject-face and
notmuch-tag-face. The first face is used to show the subject
line in the notmuch-show-mode and the second one to show tags
in the notmuch-search-mode.
We can selectively highlight each tag by setting notmuch-tag-face-alist as below
(defface notmuch-tag-unread-face
'((((class color) (background light)) (:foreground "goldenrod" :bold t))
(((class color) (background dark)) (:foreground "goldenrod" :bold t)))
"Notmuch search mode face used to highligh tags.")
(defface notmuch-tag-inbox-face
'((((class color) (background light)) (:foreground "red" :bold t))
(((class color) (background dark)) (:foreground "red" :bold t)))
"Notmuch search mode face used to highligh tags.")
(setq notmuch-tag-face-alist '(("unread" . 'notmuch-tag-unread-face)
("inbox" . 'notmuch-tag-inbox-face)))
(require 'notmuch)
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
notmuch.el | 40 ++++++++++++++++++++++++++++++++++++++--
1 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/notmuch.el b/notmuch.el
index 1f24461..2aa6d5a 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -686,6 +686,18 @@ which this thread was originally shown."
(force-window-update)
(redisplay t))
+(defface notmuch-show-subject-face
+ '((((class color) (background light)) (:foreground "yellow" :bold t))
+ (((class color) (background dark)) (:foreground "yellow" :bold t)))
+ "Notmuch show mode face used to highligh subject line."
+ :group 'notmuch)
+
+(defvar notmuch-show-font-lock-keywords
+ (list ;; header in font-lock-type-face
+ (list "\\(Subject:.*$\\)"
+ '(1 'notmuch-show-subject-face)))
+ "Additonal expression to hightlight in notmuch-show-mode")
+
;;;###autoload
(defun notmuch-show-mode ()
"Major mode for viewing a thread with notmuch.
@@ -726,7 +738,9 @@ view, (remove the \"inbox\" tag from each), with
(use-local-map notmuch-show-mode-map)
(setq major-mode 'notmuch-show-mode
mode-name "notmuch-show")
- (setq buffer-read-only t))
+ (setq buffer-read-only t)
+ (set (make-local-variable 'font-lock-defaults)
+ '(notmuch-show-font-lock-keywords t)))
;;;###autoload
@@ -855,6 +869,17 @@ thread from that buffer can be show when done with this one)."
(goto-char (point-max))
(forward-line -1))
+(defface notmuch-tag-face
+ '((((class color) (background light)) (:foreground "goldenrod" :bold t))
+ (((class color) (background dark)) (:foreground "goldenrod" :bold t)))
+ "Notmuch search mode face used to highligh tags."
+ :group 'notmuch)
+
+(defvar notmuch-tag-face-alist nil
+ "List containing the tag list that need to be highlighed")
+
+(defvar notmuch-search-font-lock-keywords nil)
+
;;;###autoload
(defun notmuch-search-mode ()
"Major mode for searching mail with notmuch.
@@ -885,7 +910,18 @@ global search.
(setq truncate-lines t)
(setq major-mode 'notmuch-search-mode
mode-name "notmuch-search")
- (setq buffer-read-only t))
+ (setq buffer-read-only t)
+ (if (not notmuch-tag-face-alist)
+ (add-to-list 'notmuch-search-font-lock-keywords (list
+ "\\(([^)]*)$\\)" '(1 'notmuch-tag-face)))
+ (progn
+ (setq notmuch-search-tags (mapcar 'car notmuch-tag-face-alist))
+ (loop for notmuch-search-tag in notmuch-search-tags
+ do (add-to-list 'notmuch-search-font-lock-keywords (list
+ (concat "\\(" notmuch-search-tag "\\)")
+ `(1 ,(cdr (assoc notmuch-search-tag notmuch-tag-face-alist))))))))
+ (set (make-local-variable 'font-lock-defaults)
+ '(notmuch-search-font-lock-keywords t)))
(defun notmuch-search-find-thread-id ()
(save-excursion
--
1.6.5.2.74.g610f9
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -v3] notmuch.el: Add face support to search and show mode
2009-11-23 5:21 [PATCH -v3] notmuch.el: Add face support to search and show mode Aneesh Kumar K.V
@ 2009-11-26 20:56 ` Carl Worth
0 siblings, 0 replies; 2+ messages in thread
From: Carl Worth @ 2009-11-26 20:56 UTC (permalink / raw)
To: Aneesh Kumar K.V, notmuch
On Mon, 23 Nov 2009 10:51:20 +0530, "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> wrote:
> This add two faces, notmuch-show-subject-face and
> notmuch-tag-face. The first face is used to show the subject
> line in the notmuch-show-mode and the second one to show tags
> in the notmuch-search-mode.
I mentioned in IRC that I think we can simplify things here by just
using existing message-mode faces rather than inventing new faces for
things like the subject header.
We're already depending on message-mode for composition, so it would be
nice if our presentation of messages looked the same, and very nice if
both presentation and composition could be customized in a single place.
Obviously, message-mode doesn't have anything specific for tags, so I'd
be happy to see a patch that add just the addition of special face
treatment for tags.
-Carl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-26 20:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-23 5:21 [PATCH -v3] notmuch.el: Add face support to search and show mode Aneesh Kumar K.V
2009-11-26 20:56 ` Carl Worth
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).