unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: Gregor Hoffleit <gregor@hoffleit.de>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] json_quote_str should handle non-ASCII characters
Date: Tue, 13 Apr 2010 08:36:06 -0700	[thread overview]
Message-ID: <87r5mje55l.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1267697893-sup-4538@sam.mediasupervision.de>

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

On Thu, 04 Mar 2010 11:40:03 +0100, Gregor Hoffleit <gregor@hoffleit.de> wrote:
> The current code in json_quote_str() only accepts strict printable ASCII
> code points (i.e. 32-127), all other code points are dropped from the
> JSON output.
> 
> This patch accepts code points 32-255.

Thanks, Gregor!

I've pushed this patch out now.

And I noted in our TODO file that we really should add some tests to the
test suite to exercise our --format=json code paths. It would be nice to
ensure we don't have any regressions in this area later.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2010-04-13 15:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-04 10:40 [PATCH] json_quote_str should handle non-ASCII characters Gregor Hoffleit
2010-03-04 13:57 ` Sebastian Spaeth
2010-03-04 14:26   ` Gregor Hoffleit
2010-04-13 15:36 ` Carl Worth [this message]
2010-04-13 16:37   ` [PATCH] First tests for JSON output and UTF-8 in mail body and subject Gregor Hoffleit
2010-04-15  0:35     ` Carl Worth
2010-04-15  8:33       ` Michal Sojka
2010-04-15 19:58         ` Carl Worth
2010-04-16  8:17           ` Michal Sojka
2010-04-22 21:14             ` Improved diff-based failure reports from the test suite Carl Worth
2010-04-16 11:49       ` [PATCH] First tests for JSON output and UTF-8 in mail body and subject David Edmondson
2010-04-23  0:15       ` Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r5mje55l.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=gregor@hoffleit.de \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).