From: Jameson Rollins <jrollins@finestructure.net>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Remove `notmuch-search-authors-width' and fix the use of `notmuch-search-result-format' accordingly
Date: Fri, 23 Apr 2010 13:22:24 -0400 [thread overview]
Message-ID: <87r5m6ulrj.fsf@servo.finestructure.net> (raw)
In-Reply-To: <1272018249-10300-1-git-send-email-dme@dme.org>
[-- Attachment #1: Type: text/plain, Size: 1019 bytes --]
On Fri, 23 Apr 2010 11:24:09 +0100, David Edmondson <dme@dme.org> wrote:
> Jamie, could you test this patch please? My main concern is that it
> makes a small assumption about the value of
> `notmuch-search-result-format' - namely that the `authors' field ends
> with a space.
Tested, and it works. Thanks so much for fixing this, David. Very much
appreciated.
So this patch gets rid of the notmuch-search-authors-width variable
entirely. That variable was somewhat convenient (for me at least, since
that was the only thing in the format i wanted to adjust), but I think
the new configuration is more straightforward. Just set
notmuch-search-result-format how you want it to be, and it Just Works.
I think we should go with this solution...
Approved-By: Jameson Rollins <jrollins@finestructure.net>
(I was going to try to resend the patch with the "Approved-By" bit
added, but I was sure I was going to mess it up. If someone can point
me to a message where that was done correctly, that'd be great.)
jamie.
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next prev parent reply other threads:[~2010-04-23 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 23:09 problem with notmuch-search-authors-width in JSON emacs implementation Jameson Rollins
2010-04-21 23:23 ` Dirk Hohndel
2010-04-22 4:37 ` Jameson Rollins
2010-04-22 7:52 ` David Edmondson
2010-04-22 13:22 ` Jameson Rollins
2010-04-22 14:04 ` David Edmondson
2010-04-22 14:12 ` Jameson Rollins
2010-04-22 14:38 ` David Edmondson
2010-04-22 15:20 ` Jameson Rollins
2010-04-22 16:44 ` David Edmondson
2010-04-23 10:24 ` [PATCH] emacs: Remove `notmuch-search-authors-width' and fix the use of `notmuch-search-result-format' accordingly David Edmondson
2010-04-23 17:22 ` Jameson Rollins [this message]
2010-04-23 19:17 ` Carl Worth
2010-04-26 12:16 ` [PATCH] emacs: Fix `notmuch-search-insert-field' David Edmondson
2010-04-26 15:25 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5m6ulrj.fsf@servo.finestructure.net \
--to=jrollins@finestructure.net \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).