From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id DDAE2429E25 for ; Wed, 25 May 2011 15:17:14 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0.01 X-Spam-Level: X-Spam-Status: No, score=0.01 tagged_above=-999 required=5 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HHcp5KFzQMtD for ; Wed, 25 May 2011 15:17:14 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 51036431FB6 for ; Wed, 25 May 2011 15:17:14 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id C321629A052; Wed, 25 May 2011 15:17:12 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id AEBE425417E; Wed, 25 May 2011 15:17:12 -0700 (PDT) From: Carl Worth To: Thomas Jost , Stewart Smith , notmuch Subject: Re: [PATCH] emacs: Allow user to choose "From" address when composing a new message. In-Reply-To: <87lixu7w71.fsf@thor.loria.fr> References: <87vcxb0za4.fsf@flamingspork.com> <87wrhfvk6a.fsf@yoom.home.cworth.org> <87lixvvjty.fsf@yoom.home.cworth.org> <87lixu7w71.fsf@thor.loria.fr> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Wed, 25 May 2011 15:17:05 -0700 Message-ID: <87r57ma0im.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2011 22:17:15 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Wed, 25 May 2011 15:21:06 +0200, Thomas Jost wro= te: > Thanks, IMHO that's better than my previous solution. And it makes my > .emacs smaller, woohoo! :) Thanks for the review. > One little issue though: you did not update notmuch-show-mode-map in > notmuch-show.el. I'll reply with a patch that fixes that (or you can > just integrate it in your commit when pushing it). Good catch. > I'll also send a few additional patches that make it possible to choose > the "From" address when forwarding a message and when replying to a > message. The only real concern I have with the series is that it grabs 'R' for reply-with-custom-from where I've been planning to implement 'R' as reply-to-sender-only, (a long-missing and often-requested feature). When I first started implementing the custom-from feature I planned to use a prefix argument to get the behavior (such as "C-u m" rather than "M" for compose-new-mail-with-custom-from). You might even see I've got some code written along those lines. When I went to test it though, it didn't work. That was probably some silly mistake on my part, (we do already have working code that changes behavior with a prefix argument in the case of "M-RET" for example). If you want to update the series to move away from capital-letter keybindings in favor of a prefix argument, I'll be glad to accept it. Otherwise, I might get around to doing that myself at some point. Thanks again, =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3df+EACgkQ6JDdNq8qSWhPJgCgk5FFqAGUWNtli9wTDWqWErtb ehIAn33Zj0SjgW91NBGMYhDOMK857sAr =Dvhd -----END PGP SIGNATURE----- --=-=-=--