From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id B7834431FD0 for ; Fri, 3 Jun 2011 12:56:57 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mOmNjfiB63Gn for ; Fri, 3 Jun 2011 12:56:57 -0700 (PDT) Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2]) by olra.theworths.org (Postfix) with ESMTP id 0A0B4431FB6 for ; Fri, 3 Jun 2011 12:56:57 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id EA13D29A047; Fri, 3 Jun 2011 12:56:55 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id D96DB54C02C; Fri, 3 Jun 2011 12:56:55 -0700 (PDT) From: Carl Worth To: Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH 25/25] Fix stdout stream grabbing in format_part_content_text In-Reply-To: <1306619520-25730-26-git-send-email-jrollins@finestructure.net> References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net> <1306619520-25730-2-git-send-email-jrollins@finestructure.net> <1306619520-25730-3-git-send-email-jrollins@finestructure.net> <1306619520-25730-4-git-send-email-jrollins@finestructure.net> <1306619520-25730-5-git-send-email-jrollins@finestructure.net> <1306619520-25730-6-git-send-email-jrollins@finestructure.net> <1306619520-25730-7-git-send-email-jrollins@finestructure.net> <1306619520-25730-8-git-send-email-jrollins@finestructure.net> <1306619520-25730-9-git-send-email-jrollins@finestructure.net> <1306619520-25730-10-git-send-email-jrollins@finestructure.net> <1306619520-25730-11-git-send-email-jrollins@finestructure.net> <1306619520-25730-12-git-send-email-jrollins@finestructure.net> <1306619520-25730-13-git-send-email-jrollins@finestructure.net> <1306619520-25730-14-git-send-email-jrollins@finestructure.net> <1306619520-25730-15-git-send-email-jrollins@finestructure.net> <1306619520-25730-16-git-se nd-email-jrollins@finestructure.net> <1306619520-25730-17-git-send-email-jrollins@finestructure.net> <1306619520-25730-18-git-send-email-jrollins@finestructure.net> <1306619520-25730-19-git-send-email-jrollins@finestructure.net> <1306619520-25730-20-git-send-email-jrollins@finestructure.net> <1306619520-25730-21-git-send-email-jrollins@finestructure.net> <1306619520-25730-22-git-send-email-jrollins@finestructure.net> <1306619520-25730-23-git-send-email-jrollins@finestructure.net> <1306619520-25730-24-git-send-email-jrollins@finestructure.net> <1306619520-25730-25-git-send-email-jrollins@finestructure.net> <1306619520-25730-26-git-send-email-jrollins@finestructure.net> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Fri, 03 Jun 2011 12:56:50 -0700 Message-ID: <87r57almd9.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2011 19:56:57 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, 28 May 2011 14:52:00 -0700, Jameson Graef Rollins wrote: > The declaration of the GMimeStream pointer to stdout in > format_part_content_text was somehow preventing subsequent printf > calls from outputting to stdout if the output was redirected to a > file. Scoping the declaration to the actual use of the stream pointer > works around this problem. This commit message sounds like we don't actually understand the problem being fixed here. I'd like to investigate this more. Perhaps with a test case? Otherwise, the patches up to this point in the thread have all either been pushed or I've asked for some additional information (perhaps that's just this patch and the "old style fcc dirs" patch?). I'll continue to work through my patch queue as contained in email messages. I'm finding it easier to do that (and just piping the patches I like to "git am") as opposed to working through a release-candidate branch in git, (and having to keep rebasing/postponing it after I reject some patch in the series). I'm actually a bit surprised to see myself preferring patches in email. When Linus first wrote git, I couldn't understand why the Linux community kept to such a consistent culture of sending patches via email. It seemed so backwards to do these awkward machinations (git format-patch, git send-email, SMTP, MUA, git am), and risk all the problems of email clients corrupting patches, etc.=E2=80=94especially when = git has such clean mechanisms for reliably moving patches around (git push, git pull). Call me converted. Email really is the right way to do collaborative code development. =2DCarl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk3pPIIACgkQ6JDdNq8qSWhPawCePe9T2KBadwP2rhfaY0aPqOVx OZQAn3b4zv8JccIp37uxcOOyEsPHS/xE =aA8X -----END PGP SIGNATURE----- --=-=-=--