From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E3586431FD0 for ; Fri, 8 Jul 2011 15:03:46 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.71 X-Spam-Level: * X-Spam-Status: No, score=1.71 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HDQyhKaZcXHS for ; Fri, 8 Jul 2011 15:03:46 -0700 (PDT) Received: from mail-fx0-f46.google.com (mail-fx0-f46.google.com [209.85.161.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E7E3E431FB6 for ; Fri, 8 Jul 2011 15:03:45 -0700 (PDT) Received: by fxh19 with SMTP id 19so2484946fxh.19 for ; Fri, 08 Jul 2011 15:03:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=vNNu+8DfC2NUOgRPKEgQN/V3BetLC+vbtA2ZAhnskz0=; b=c0mEBqaCuK3eCnC5C49i045xk3m3eKI+eVhwli8Icd8JVuDSc+iR/Z4Kx4IRdWKq/X QJR7WQVx/XWpK7OOKx2kwunDMb4xUhmMWK9NsawsIyHwQk3+T6LyXUqrg8tgFLor+feM 22M5cWFqzXrvtL9SwfGgKS/SgJQ6ky6wmCmVY= Received: by 10.223.27.71 with SMTP id h7mr3693227fac.142.1310162624457; Fri, 08 Jul 2011 15:03:44 -0700 (PDT) Received: from localhost (dslb-178-004-020-175.pools.arcor-ip.net [178.4.20.175]) by mx.google.com with ESMTPS id d15sm1010648fan.2.2011.07.08.15.03.42 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Jul 2011 15:03:43 -0700 (PDT) From: Daniel Schoepe To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH v3 1/2] emacs: User-defined sections in notmuch-hello In-Reply-To: <87k4bs4gbn.fsf@steelpick.2x.cz> References: <1309379221-5617-1-git-send-email-daniel.schoepe@googlemail.com> <1309883030-28899-1-git-send-email-daniel.schoepe@googlemail.com> <1309883030-28899-2-git-send-email-daniel.schoepe@googlemail.com> <87fwmjabii.fsf@steelpick.2x.cz> <87oc17r38a.fsf@tredergarh.home.box> <871uy25d3y.fsf@steelpick.2x.cz> <87wrfuc5i6.fsf@gilead.invalid> <87k4bs4gbn.fsf@steelpick.2x.cz> User-Agent: Notmuch/0.5-329-g0b5d38d (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 09 Jul 2011 00:03:28 +0200 Message-ID: <87r5602zwu.fsf@gilead.invalid> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2011 22:03:47 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Fri, 08 Jul 2011 23:23:40 +0200, Michal Sojka wrot= e: > OK. I changed my mind. I thought that the approach with 'notmuch > search-tags QEURY' followed by 'notmuch count tag:XXX and QUERY' for > returned tags would be faster then 'notmuch search-tags' followed by > 'notmuch count tag:XXX and QUERY' for all tags, but it turned out not to > be the case. For me, the stronger argument was that the code would have been simpler, because notmuch-hello refreshes don't happen that often that performance shouldn't matter much. >=20 > I played with the customization interface a bit and found the following > problems: >=20 > - It is annoying to insert section titles that includes ": " at the end > in order to be nicely "rendered". I think this could be appended > automatically. Agreed. >=20 > - :hide-empty-tags should be renamed in :hide-empty-searches to be > effective (see the patch below). This has been done in v4 of the patch, for which I screwed up the In-Reply-To header and hence is listed as a separate thread: id:"1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com" >=20 > - The title of custom tags section was not passed correctly to the > functions. This is also fixed in the patch below. I changed title to a mandatory argument for consistency with notmuch-insert-searches and because a title-less section wouldn't make much sense anyway. Cheers, Daniel --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOF36xAAoJEIaTAtce+Z+Je6MP/RDhXjV/0JFI39foNYGC12LX VD5nnwFkJb3rF/AGhwIil7HbII2UVbqi+xaug8sfhSy6HDgBzfpl1EMKH1qrk2p/ +tsmgV60Tqz5o9WKXNiiWgXal/XyWnW64+DOAi3GD0m+HmmGpCs1dDZ35EF7TS0C AiKzWJKcb1ek9c+2h+VyIBhlu8UbmfG5CePSQ2h6j+xCpIH2HhJtY17hpkW4ZjLN 43kVwhvL7OZoWDbVej8RFINvStp4CE+/rhIhaRzH1VEpGjvyieBfPReVxC2zmC0r QpLS/DwAUlur/Vo720LpA2suUIg8Sst3LuJJy/cJHUKOYqBlVpKDM27NLFMZ8NLX DhjLxEje5AbN8v9fLOHeNB2p3zmwxOh3hdOjcTe2GBw3go+T2KxH3cfr4YgQektB QVl2Fq2oCBdcGY/tq5iuJ0aI4DQeLkImL8gBKrnR/qovBmW87ab6I5pPOSBNt2dx +oklcaAgdujsDv/6Xs1poUaHKzQmyiyEXX0P9j/sjpsl1O1r+rVP7xUnKVn2s5bF Mi7lkGL7PisJuIFd4mQMB4LdZAYIc0mQWgUIiCpmsoBtGPwdPgrotMr36Qf5a2PK BFDaCJodz8+wB3N5/Hg0sk+wc4WJrp+8n1ILEvYZLgpLYNE1Iw4ZGNV2SJ6Xzreq ynCIWGVfyS/9bsEVM6ih =3nnj -----END PGP SIGNATURE----- --=-=-=--