Re: [PATCH v3 1/2] emacs: User-defined sections in notmuch-hello

[Daniel Schoepe <daniel.schoepe@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]

On Fri, 08 Jul 2011 23:23:40 +0200, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> OK. I changed my mind. I thought that the approach with 'notmuch
> search-tags QEURY' followed by 'notmuch count tag:XXX and QUERY' for
> returned tags would be faster then 'notmuch search-tags' followed by
> 'notmuch count tag:XXX and QUERY' for all tags, but it turned out not to
> be the case.

For me, the stronger argument was that the code would have been simpler,
because notmuch-hello refreshes don't happen that often that performance
shouldn't matter much.

> 
> I played with the customization interface a bit and found the following
> problems:
> 
> - It is annoying to insert section titles that includes ": " at the end
>   in order to be nicely "rendered". I think this could be appended
>   automatically.

Agreed.

> 
> - :hide-empty-tags should be renamed in :hide-empty-searches to be
>   effective (see the patch below).

This has been done in v4 of the patch, for which I screwed up the
In-Reply-To header and hence is listed as a separate thread:

id:"1310079227-19120-1-git-send-email-daniel.schoepe@googlemail.com"

> 
> - The title of custom tags section was not passed correctly to the
>   functions. This is also fixed in the patch below.

I changed title to a mandatory argument for consistency with
notmuch-insert-searches and because a title-less section wouldn't make
much sense anyway.

Cheers,
Daniel

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]