From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BED94429E25 for ; Fri, 19 Aug 2011 08:38:02 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.363 X-Spam-Level: * X-Spam-Status: No, score=1.363 tagged_above=-999 required=5 tests=[RDNS_DYNAMIC=0.363, TO_NO_BRKTS_DYNIP=1] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BvH0IJjrokyE for ; Fri, 19 Aug 2011 08:38:02 -0700 (PDT) Received: from hackervisions.org (67-207-143-141.slicehost.net [67.207.143.141]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 36221431FD0 for ; Fri, 19 Aug 2011 08:38:02 -0700 (PDT) Received: from ool-4572d87b.dyn.optonline.net ([69.114.216.123] helo=localhost) by hackervisions.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QuR9u-0007Zg-1j; Fri, 19 Aug 2011 11:38:58 -0400 From: James Vasile To: Michal Sojka , notmuch@notmuchmail.org Subject: Re: [PATCH] Return maximum of 150 results In-Reply-To: <87mxf5v43c.fsf@steelpick.2x.cz> References: <87zkj6um50.fsf@opensourcematters.org> <87mxf5v43c.fsf@steelpick.2x.cz> User-Agent: Notmuch/0.6.1-213-ge89ce87 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Fri, 19 Aug 2011 11:37:54 -0400 Message-ID: <87r54hv2ct.fsf@opensourcematters.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2011 15:38:02 -0000 On Fri, 19 Aug 2011 17:00:23 +0200, Michal Sojka wrote: > Hi James, > > On Fri, 19 Aug 2011, James Vasile wrote: > > Display a maximum of 150 results when searching for messages. This > > prevents client lag when searches return thousands of results you'll > > never look at > > I would not like this feature. If I search for something I really want > to see everything. For example, if I want to remove inbox from many > messages, I would search for them and press "-inbox". With your > patch I'd not be sure whether there are some more messages or not. Ah, I do such things from the commandline, but you are right that there is a good use for such. > > > (use the Filter command to cut down results that exceed 150). > > You can start filtering while the previous search is still running, so I > do not see problem with having bug number of results. Yes, you can filter while the search runs, but that's not the only problem with huge search results. On my system, I routinely do searches that return 15000+ messages when I'm only interested in the first several. When I hit Q, Emacs annoyingly asks me for permission to kill the buffer because it has a running process. And emacs lags as it processes all that data. > > > > Number of results can be changed by setting notmuch-max-results. > > If you really want this behavior, I propose to make the default value > of notmuch-max-results infinity. Yes, that's probably the right answer. I'll rework the patch to do that.