From: Jani Nikula <jani@nikula.org>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] Use invisibility to toggle display of all parts including multipart
Date: Wed, 05 Dec 2012 19:24:54 +0200 [thread overview]
Message-ID: <87r4n4jtsp.fsf@nikula.org> (raw)
In-Reply-To: <1354663662-20524-1-git-send-email-markwalters1009@gmail.com>
Hi Mark -
On Wed, 05 Dec 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This patch aims to do the same as
> id:1354496317-24564-1-git-send-email-markwalters1009@gmail.com but
> rather than reloading the buffer it uses invisibility.
>
> Most of the invisibility stuff was taken from notmuch-wash and adapted
> to this situation.
>
> The general interface is that any part can have its visibility
> toggled: in this version by "t" on the part button. In addition "RET"
> on the part button of any "not shown" part will show it.
I tested the patches (did not look at the code), and with the addition
of your RET patch on top, I think the series is perfect! I very much
like the functionality. Must have.
> Whilst a main driver was being able to view different parts of a
> multipart/alternative message, this also allows the user to toggle
> images or large inline text attachments (eg text/x-tex) for
> example. Indeed, even multipart part buttons can be toggled which
> remove the whole tree beneath: it is unclear whether this last is useful.
It's very nice that this is a general solution showing/hiding parts, and
the original multipart/alternative problem is just a special case this
handles. And if there's any more tweaking the special case needs, it
should be done on top of this series, afterwards.
> The invisibility approach has some advantages over the reloading
> approach. It does not disrupt the rest of the buffer (eg
> collapsed/expanded citations remain), it does not require an extra
> call to the database with the possible addition of messages to the
> buffer, and it fits more naturally with the other hidden/not-hidden
> items.
Yes, much better than the original (which already was good).
Thanks for doing this.
BR,
Jani.
>
> Best wishes
>
> Mark
>
>
> Mark Walters (3):
> emacs: show: modify insert-part-header to save the button text
> emacs: show: add overlays for each part
> emacs: show: add invisibility button action
>
> emacs/notmuch-show.el | 117 +++++++++++++++++++++++++++++++++++++++----------
> 1 files changed, 93 insertions(+), 24 deletions(-)
>
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
prev parent reply other threads:[~2012-12-05 17:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 23:27 [PATCH 0/3] Use invisibility to toggle display of all parts including multipart Mark Walters
2012-12-04 23:27 ` [PATCH 1/3] emacs: show: modify insert-part-header to save the button text Mark Walters
2012-12-11 0:22 ` Austin Clements
2012-12-04 23:27 ` [PATCH 2/3] emacs: show: add overlays for each part Mark Walters
2012-12-11 3:59 ` Austin Clements
2012-12-13 8:54 ` Mark Walters
2012-12-15 5:16 ` Austin Clements
2012-12-04 23:27 ` [PATCH 3/3] emacs: show: add invisibility button action Mark Walters
2012-12-05 9:41 ` [PATCH] emacs: show: make RET always toggle parts where plausible Mark Walters
2012-12-11 4:07 ` Austin Clements
2012-12-11 4:06 ` [PATCH 3/3] emacs: show: add invisibility button action Austin Clements
2012-12-13 8:57 ` Mark Walters
2012-12-05 17:24 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4n4jtsp.fsf@nikula.org \
--to=jani@nikula.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).