From: Jani Nikula <jani@nikula.org>
To: Michal Nazarewicz <mina86@mina86.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] test: fix count test
Date: Wed, 05 Dec 2012 23:23:22 +0200 [thread overview]
Message-ID: <87r4n4chx1.fsf@nikula.org> (raw)
In-Reply-To: <xa1t624g6yvl.fsf@mina86.com>
On Wed, 05 Dec 2012, Michal Nazarewicz <mina86@mina86.com> wrote:
> Hmm, I thought I've already replied to this email, but it still sticks
> as unread. In case I did, sorry for duplicate.
>
> On Wed, Dec 05 2012, Jani Nikula wrote:
>> Please try this patch, which should pass if everything were all right:
>>
>> diff --git a/test/count b/test/count
>> index 300b171..ecae40e 100755
>> --- a/test/count
>> +++ b/test/count
>> @@ -6,6 +6,11 @@ add_email_corpus
>>
>> SEARCH="\"*\""
>>
>> +test_begin_subtest "check the query"
>> +test_expect_equal \
>> + "`notmuch count ${SEARCH}`" \
>> + "`notmuch count '*'`"
>> +
>> test_begin_subtest "message count is the default for notmuch count"
>> test_expect_equal \
>> "`notmuch search --output=messages ${SEARCH} | wc -l`" \
>
> Yeah, you're right, sorry for the commotion.
No worries. I wrote the test originally, and I thought it was all right
too...
Jani.
next prev parent reply other threads:[~2012-12-05 21:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 21:26 [PATCH 0/3] test fixes, portability Jani Nikula
2012-12-04 21:26 ` [PATCH 1/3] test: fix count test Jani Nikula
2012-12-04 23:04 ` Michal Nazarewicz
2012-12-05 8:05 ` Jani Nikula
2012-12-05 20:13 ` Michal Nazarewicz
2012-12-05 21:23 ` Jani Nikula [this message]
2012-12-06 13:45 ` Michal Nazarewicz
2012-12-04 21:26 ` [PATCH 2/3] test: wrap 'wc -l' results in arithmetic evaluation to strip whitespace Jani Nikula
2012-12-04 21:26 ` [PATCH 3/3] test: use perl instead of sed -r for portability Jani Nikula
2012-12-04 23:01 ` Michal Nazarewicz
2012-12-05 8:13 ` Jani Nikula
2012-12-04 22:55 ` [PATCH 0/3] test fixes, portability Tomi Ollila
2012-12-08 13:35 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4n4chx1.fsf@nikula.org \
--to=jani@nikula.org \
--cc=mina86@mina86.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).