From: Mark Walters <markwalters1009@gmail.com>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: v3 of --stderr=FILE patches
Date: Wed, 29 May 2013 19:21:23 +0100 [thread overview]
Message-ID: <87r4gphckc.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1369766335-26733-1-git-send-email-tomi.ollila@iki.fi>
Just confirming LGTM +1 for this version too.
Best wishes
Mark
Tomi Ollila <tomi.ollila@iki.fi> writes:
> This is v3 of id:1369557954-13439-1-git-send-email-tomi.ollila@iki.fi
>
> In id:m2a9nfr4tb.fsf@guru.guru-group.fi I suggested to use 0600 as
> permission bits so that files written to /tmp would not have write
> bits set in any case. That would have been inconsistent what is
> normally expected in redirection cases. The problem I described
> is easily avoided in emacs as (make-temp-file "nmerr") will create
> file "/tmp/nmerrXXXXXX" with permissions 0600 -- and writing to
> that already-created file will not change its permissions. Writing
> elsewhere is usually covered with directory permissions.
>
>
> Diffdiff from v2 is shown below.
>
> diff --git a/NEWS b/NEWS
> index 990b038..80abd97 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -38,8 +38,7 @@ Top level option to specify configuration file
> Top level option to redirect writes to stderr
>
> With `notmuch --stderr=FILE` all writes to stderr are redirected to
> - the specified file. If the file name is a plain '-', stderr is
> - written to stdout.
> + the specified file. If FILE is '-', stderr is redirected to stdout.
>
> Deprecated commands "part" and "search-tags" are removed.
>
> diff --git a/man/man1/notmuch.1 b/man/man1/notmuch.1
> index fbd575a..f5ca0ad 100644
> --- a/man/man1/notmuch.1
> +++ b/man/man1/notmuch.1
> @@ -83,7 +83,7 @@ configuration file specified by ${NOTMUCH_CONFIG}.
> .B \-\-stderr=FILE
>
> Redirect all writes to stderr to the specified file.
> -If the file name is a plain '-', stderr is written to stdout.
> +If FILE is '-', stderr is redirected to stdout.
> .RE
>
> .SH COMMANDS
> diff --git a/notmuch.c b/notmuch.c
> index 654a568..15e90c8 100644
> --- a/notmuch.c
> +++ b/notmuch.c
> @@ -260,7 +260,7 @@ redirect_stderr (const char * stderr_file)
> return 1;
> }
> } else {
> - int fd = open (stderr_file, O_WRONLY|O_CREAT|O_APPEND, 0644);
> + int fd = open (stderr_file, O_WRONLY|O_CREAT|O_TRUNC, 0666);
> if (fd < 0) {
> fprintf (stderr, "Error: Cannot redirect stderr to '%s': %s\n",
> stderr_file, strerror (errno));
>
>
> From Tomi Ollila <tomi.ollila@iki.fi> # This line is ignored.
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-05-29 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 18:38 v3 of --stderr=FILE patches Tomi Ollila
2013-05-28 18:38 ` [PATCH v3 1/4] cli: add global option --stderr=FILE Tomi Ollila
2013-05-28 18:38 ` [PATCH v3 2/4] test: added --stderr=FILE tests Tomi Ollila
2013-05-28 18:38 ` [PATCH v3 3/4] man: documented --stderr=FILE in notmuch.1 manual page Tomi Ollila
2013-05-28 18:38 ` [PATCH v3 4/4] NEWS: added information about new --stderr=FILE top level option Tomi Ollila
2013-05-29 18:21 ` Mark Walters [this message]
2013-05-29 20:34 ` v3 of --stderr=FILE patches Austin Clements
2013-05-29 23:52 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4gphckc.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).