[PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

[PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

[Mark Walters]

Previously pick set a prefix argument prior to calling show in the
message pane to tell show to only show matching messages. This sets
notmuch-show-only-matching-messages instead which is much cleaner and
will work even if the user has configured show to default to showing
only matching messages.
---
 contrib/notmuch-pick/notmuch-pick.el |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
index 9079acf..2da43ea 100644
--- a/contrib/notmuch-pick/notmuch-pick.el
+++ b/contrib/notmuch-pick/notmuch-pick.el
@@ -376,8 +376,8 @@ Does NOT change the database."
 	    (split-window-vertically (/ (window-height) 4)))
       (with-selected-window notmuch-pick-message-window
 	;; Since we are only displaying one message do not indent.
-	(let ((notmuch-show-indent-messages-width 0))
-	  (setq current-prefix-arg '(4))
+	(let ((notmuch-show-indent-messages-width 0)
+	      (notmuch-show-only-matching-messages t))
 	  (setq buffer (notmuch-show id nil nil nil))))
       ;; We need the `let' as notmuch-pick-message-window is buffer local.
       (let ((window notmuch-pick-message-window))
-- 
1.7.9.1

Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

[Tomi Ollila]

On Sun, Jun 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously pick set a prefix argument prior to calling show in the
> message pane to tell show to only show matching messages. This sets
> notmuch-show-only-matching-messages instead which is much cleaner and
> will work even if the user has configured show to default to showing
> only matching messages.
> ---

LGTM.

Tomi


>  contrib/notmuch-pick/notmuch-pick.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
> index 9079acf..2da43ea 100644
> --- a/contrib/notmuch-pick/notmuch-pick.el
> +++ b/contrib/notmuch-pick/notmuch-pick.el
> @@ -376,8 +376,8 @@ Does NOT change the database."
>  	    (split-window-vertically (/ (window-height) 4)))
>        (with-selected-window notmuch-pick-message-window
>  	;; Since we are only displaying one message do not indent.
> -	(let ((notmuch-show-indent-messages-width 0))
> -	  (setq current-prefix-arg '(4))
> +	(let ((notmuch-show-indent-messages-width 0)
> +	      (notmuch-show-only-matching-messages t))
>  	  (setq buffer (notmuch-show id nil nil nil))))
>        ;; We need the `let' as notmuch-pick-message-window is buffer local.
>        (let ((window notmuch-pick-message-window))
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix

[David Bremner]

Mark Walters <markwalters1009@gmail.com> writes:

> Previously pick set a prefix argument prior to calling show in the
> message pane to tell show to only show matching messages. This sets
> notmuch-show-only-matching-messages instead which is much cleaner and
> will work even if the user has configured show to default to showing
> only matching messages.

pushed.

d