From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH RFC] Emacs: Add address completion mechanism implemented in elisp
Date: Mon, 11 Aug 2014 16:31:06 +0200 [thread overview]
Message-ID: <87r40np07p.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <87r411f604.fsf@maritornes.cs.unb.ca>
Hi David,
On Fri, Aug 01 2014, David Bremner wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
>
>> notmuch-company.el hooks itself into message-mode and uses
>> company-mode to offer the completion to the user. The file is put into
>> the contrib directory which means that the use has to install it
>> himself. This is because company-mode is not a part of Emacs and
>> bytecompiling notmuch-company.el fails due to used --quick option that
>> causes user installed packages to be ignored.
>
> what about for now just putting
>
> ;; -*-no-byte-compile: t; -*-
>
> at the top of the file? It seems usable uncompiled to me.
>
> Then somebody who really wants it compiled can figure out how to do the
> conditional compilation.
>
>> It would probably make sense to implement another completion frontend
>> based only on Emacs built-in functionality and integrate it with
>> notmuch-addresses.el.
>
> Agreed.
>
>> + "`company-mode' completion back-end for `nevermore (nm)'."
>
> missed "nevermore" ;)
>
>
>>
>> +(defun notmuch-flatten-thread-set (thread-set)
>> + "Convert the result of 'notmuch show' to the plain list of messages."
>> +(defun notmuch-flatten-thread (thread)
>> +
>> +(defun notmuch-flatten-thread-node (thread-node)
>
>
> what about putting those functions in notmuch-query.el?
>
>
>> +(defun notmuch-async-harvest ()
>> + "Collect possible addresses for completion. It queries the
>
>
> logically it seems like this might belong in notmuch-address.el,
> even if none of the functions in in it currently use
Thanks for the comments. I incorporated them in a new version of the
patch, which I'll send in a while.
-Michal
next prev parent reply other threads:[~2014-08-11 14:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 14:51 nevermore Trevor Jim
2014-07-29 16:57 ` nevermore Michal Sojka
2014-07-29 16:57 ` [PATCH RFC] Emacs: Add address completion mechanism implemented in elisp Michal Sojka
2014-07-30 1:20 ` David Bremner
2014-07-30 20:41 ` Michal Sojka
2014-07-31 23:44 ` David Bremner
2014-08-11 14:31 ` Michal Sojka [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-30 22:16 Trevor Jim
2014-07-31 7:04 ` Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r40np07p.fsf@steelpick.2x.cz \
--to=sojkam1@fel.cvut.cz \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).