unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* Re: talloc_abort in notmuch_thread_get_tags () when db has been modified
@ 2016-01-18 12:45 Gaute Hope
  2016-03-07  9:14 ` Gaute Hope
  0 siblings, 1 reply; 13+ messages in thread
From: Gaute Hope @ 2016-01-18 12:45 UTC (permalink / raw)
  To: David Bremner, notmuch

David Bremner writes on January 18, 2016 13:25:
> The most likely cause of such a crash looks to me like nm_thread is NULL
> or corrupted when passed in to get_tags. It's used without checking as a
> talloc context, and that call to talloc never returns.
>

Ok, I'll check some further. I am checking whether nm_thread is NULL
though, the preceding code is as follows
(astroid/src/modes/thread_index/thread_index.cc:258):

```
    for (;
         notmuch_threads_valid (threads);
         notmuch_threads_move_to_next (threads)) {

      notmuch_thread_t  * thread;
      thread = notmuch_threads_get (threads);

      if (thread == NULL) {
        log << error << "ti: error: could not get thread." << endl;
        throw database_error ("ti: could not get thread (is NULL)");
      }

      /* test for revision discarded */
      const char * ti = notmuch_thread_get_thread_id (thread);
      if (ti == NULL) {
        log << error << "ti: revision discarded, trying to reopen." << endl;
        reopen_tries++;
        refresh (all, current_thread + count, false);
        return;
      }


      NotmuchThread *t = new NotmuchThread (thread); // get_tags is inside here

      notmuch_thread_destroy (thread);

```

(note that there is a bit of code there trying to determine whether the
db is still valid, or needs to be re-opened)

- g

^ permalink raw reply	[flat|nested] 13+ messages in thread
* talloc_abort in notmuch_thread_get_tags () when db has been modified
@ 2016-01-18  8:46 Gaute Hope
  2016-01-18 12:25 ` David Bremner
  0 siblings, 1 reply; 13+ messages in thread
From: Gaute Hope @ 2016-01-18  8:46 UTC (permalink / raw)
  To: notmuch

Hi,

a user of astroid [0] ran into a issue [1] (full trace at issue) where
reading a long query causes a talloc_abort in notmuch_thread_get_tags
(). 'notmuch new' is running at the same time, and most likely a thread
in the query has been modified since the query was done. Note that a
notmuch_thread_get_authors () call returns NULL without causing a full
crash. The code causing the crash is:

```
    for (tags = notmuch_thread_get_tags (nm_thread);
         notmuch_tags_valid (tags);
         notmuch_tags_move_to_next (tags))
    {
      tag = notmuch_tags_get (tags); // tag belongs to tags
    }

    // or db.cc:508 in astroid/src.
```

while:

```
    const char * auths = notmuch_thread_get_authors (nm_thread);
```

returns `NULL`, but does not crash.

Is there a way for me to handle this from the application side?
Admittedly I do keep query objects around for a while
(astroid/src/thread_index.cc:141), but in this case the issue would
probably occur anyway since it simply takes a long time to read the
query.

Regards, Gaute

[0] https://github.com/gauteh/astroid
[1] https://github.com/gauteh/astroid/issues/64

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2017-11-03 12:50 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-18 12:45 talloc_abort in notmuch_thread_get_tags () when db has been modified Gaute Hope
2016-03-07  9:14 ` Gaute Hope
2016-03-07 12:01   ` David Bremner
2017-02-15 22:58     ` Gaute Hope
2017-02-17 12:28       ` David Bremner
2017-02-17 14:01         ` Gaute Hope
2017-02-17 15:35           ` David Bremner
2017-11-03 10:45             ` Gaute Hope
2017-11-03 12:02               ` Gaute Hope
2017-11-03 12:18                 ` David Bremner
2017-11-03 12:50                   ` Gaute Hope
  -- strict thread matches above, loose matches on Subject: below --
2016-01-18  8:46 Gaute Hope
2016-01-18 12:25 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).