From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: third round of indexing all files
Date: Tue, 04 Apr 2017 08:10:44 -0300 [thread overview]
Message-ID: <87r318fmx7.fsf@tethera.net> (raw)
In-Reply-To: <20170404014738.25963-1-david@tethera.net>
David Bremner <david@tethera.net> writes:
> It seems noticeably faster (on the order of 30-50% faster) and the
> code is quite a bit simpler to adapt the approach in [1] to only
> delete the terms we are going to re-add via indexing.
>
> This obsoletes the previous series at [2]. It still has all of the
> issues mentioned there UI-wise, and the question of the index options
> design probably needs more thought.
>
Some belated testing reveals this implimentation is pretty broken. It
probably won't eat your database, but that's only because I forgot to
add a call to _notmuch_message_sync. So I'd recommend passing on this
for now. The previous approach is probably OK, although I'm going to
bash at this fancier approach a bit to see if I can make it work.
prev parent reply other threads:[~2017-04-04 11:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-02 13:16 second round of indexing all files David Bremner
2017-04-02 13:16 ` [rfc patch v2 1/5] lib: add definitions for notmuch_param_t David Bremner
2017-04-02 13:16 ` [rfc patch v2 2/5] added notmuch_message_reindex David Bremner
2017-04-02 13:16 ` [rfc patch v2 3/5] add "notmuch reindex" subcommand David Bremner
2017-04-02 13:16 ` [rfc patch v2 4/5] test: add known broken test for duplicate message id David Bremner
2017-04-02 13:16 ` [rfc patch v2 5/5] lib: index message files with duplicate message-ids David Bremner
2017-04-04 1:47 ` third round of indexing all files David Bremner
2017-04-04 1:47 ` [rfc patch v3 1/6] lib: add definitions for notmuch_param_t David Bremner
2017-04-04 1:47 ` [rfc patch v3 2/6] lib: add _notmuch_message_remove_indexed_terms David Bremner
2017-04-04 1:47 ` [rfc patch v3 3/6] added notmuch_message_reindex David Bremner
2017-04-04 1:47 ` [rfc patch v3 4/6] add "notmuch reindex" subcommand David Bremner
2017-04-04 1:47 ` [rfc patch v3 5/6] test: add known broken test for duplicate message id David Bremner
2017-04-04 1:47 ` [rfc patch v3 6/6] lib: index message files with duplicate message-ids David Bremner
2017-04-04 11:10 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r318fmx7.fsf@tethera.net \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).