From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 990D26DE0C6D for ; Sat, 19 Aug 2017 05:55:08 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cx26RgPQ9C3R for ; Sat, 19 Aug 2017 05:55:06 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 8AF8B6DE0C6B for ; Sat, 19 Aug 2017 05:55:06 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1dj3Dt-0003Y8-FG; Sat, 19 Aug 2017 08:51:29 -0400 Received: (nullmailer pid 14951 invoked by uid 1000); Sat, 19 Aug 2017 12:55:00 -0000 From: David Bremner To: Yuri Volchkov , notmuch@notmuchmail.org Subject: Re: [PATCH 2/4] insert: strip trailing / in folder path In-Reply-To: References: <1502556453-11609-1-git-send-email-yuri.volchkov@gmail.com> <1502556453-11609-3-git-send-email-yuri.volchkov@gmail.com> <87tw14fm22.fsf@tethera.net> Date: Sat, 19 Aug 2017 09:55:00 -0300 Message-ID: <87r2w7g1jv.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Aug 2017 12:55:08 -0000 Yuri Volchkov writes: > > This is just for consistency reasons. Fixing my problem required the > same piece of code, which was used here. Duplicating is not nice, so I > made a function around this code. That's why it feels atomic change > to me. > > I think, explanation like this is superfluously detailed. > > I can move the introduction of the strip_trailing and cleaning > notmuch_database_open_verbose into separate patch, but the fix then will > be just a one line. And I'll get unnecessarily tiny patches. I prefer the smaller commits in case there is some unforseen effect of changing notmuch_database_open_verbose; it makes it easier to use git bisect. As a commit message, it almost suffices to mention reducing code duplication, although do note this is really a change in beheviour: your new code strips multiple trailing /, while the old code did not. d