From: David Bremner <david@tethera.net>
To: Vladimir Panteleev <git@thecybershadow.net>, notmuch@notmuchmail.org
Cc: Vladimir Panteleev <git@thecybershadow.net>
Subject: Re: [PATCH 2/2] emacs: Add notmuch-update-search-tags
Date: Fri, 25 Aug 2017 08:12:34 -0300 [thread overview]
Message-ID: <87r2vz7vfh.fsf@tethera.net> (raw)
In-Reply-To: <20170814055457.7475-3-git@thecybershadow.net>
Vladimir Panteleev <git@thecybershadow.net> writes:
> Implement an option which, when enabled, causes any tag changes done
> from within notmuch-emacs to instantly update matching threads in open
> search buffers.
> ---
One side effect of this seems to be a regression, namely that in the
current buffer the "visual history" of tag changes is broken. Previously
deletions were shown by red strike-through and additions by green
underline. The deletions are now removed by the global update, and
additions shown on the wrong tags.
Another aspect that is a bit surprising is that it doesn't change whether
threads actually match. For example if I have search for tag:inbox,
adding tag inbox to a thread won't cause the corresponding thread to
show up. This is maybe defensible, but it wasn't clear to me if it was
intentional.
d
next prev parent reply other threads:[~2017-08-25 11:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-14 5:54 [PATCH 0/2] Update search results when tags change Vladimir Panteleev
2017-08-14 5:54 ` [PATCH 1/2] notmuch-tag.el: Fix minor grammar error Vladimir Panteleev
2017-08-23 11:11 ` David Bremner
2017-08-14 5:54 ` [PATCH 2/2] emacs: Add notmuch-update-search-tags Vladimir Panteleev
2017-08-25 11:12 ` David Bremner [this message]
2017-08-26 1:50 ` Vladimir Panteleev
2017-08-26 1:55 ` [PATCH v2] " Vladimir Panteleev
2017-08-26 10:23 ` Mark Walters
2017-08-26 17:15 ` Vladimir Panteleev
2017-08-27 7:46 ` Mark Walters
2017-08-29 1:18 ` David Bremner
2017-09-04 22:05 ` Vladimir Panteleev
2017-09-06 13:11 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2vz7vfh.fsf@tethera.net \
--to=david@tethera.net \
--cc=git@thecybershadow.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).