From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id F20C56DE012F for ; Mon, 28 Aug 2017 04:27:07 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.014 X-Spam-Level: X-Spam-Status: No, score=-0.014 tagged_above=-999 required=5 tests=[AWL=0.047, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.211, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7_1KvqlqYDwB for ; Mon, 28 Aug 2017 04:27:07 -0700 (PDT) Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by arlo.cworth.org (Postfix) with ESMTPS id 183A56DE00C4 for ; Mon, 28 Aug 2017 04:27:07 -0700 (PDT) Received: by mail-wr0-f173.google.com with SMTP id n37so722453wrf.4 for ; Mon, 28 Aug 2017 04:27:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version :content-transfer-encoding; bh=E1x21+oz6sXS/UHsHvv3USidYvWEsUpfZgJVMoa3mN0=; b=qPoZHgF8Jx9Zby8pUnt9QkMMkxPlNskE/cpT0dh8leL39dlxerFmnkcwOBH3/JJkbl qX8NjITfdwe7GZP5gUdtMeAlb1p0qSUrHJVEtlZVHWmJYQ0mZyiXkcqwWcWJjQW7hsUY br4ltWeaNN7SG61HKk5PtlFFjH+eWPwuFyx+C6MJR4xes7YzOG6HTN1Y/EB9+8I5mD3E lF4uI8YO21goYpf1UNW6gm3yXCx1sKTm2kRHZ+7gL7fQ9Ut1J3LGsUmNs1NINqSHbZ/9 dOydOA1H/4QVnvv96anoaMTzZ+uB38t9SE+DY4XqlJW46CkepnZxt5ukJUcR84ick7yN 22xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=E1x21+oz6sXS/UHsHvv3USidYvWEsUpfZgJVMoa3mN0=; b=nh6Ma7Smck/zdZ3RK0Qd2q58g9mBYG1spA555VI8jaqRLBAjsqN+7GC39ieDueOvjx T2qpuS/T7cW/h03dfQSiuxvKfyQd1h9+R1PUMAafX+MXk7/ngfIcTpIccIiF3FPeojBg uqRaPqtk+QckH9Wn8y9QpTAwR8KB5gCElY/CayGhABm8lIFU8Yr+7ag5UNDeRqMDZaG/ MsJzwDoI0AFTiJ0BRrm0PowXuFX+YsEw/ZniL3O1r5LycGy0n18LWKxfX+hZFa11AssR y8k0CmoRrcw6C0+lHE8HDEOD3YqiijrFbqN0wW2+TaWetRWhVye8CdvhqzgYAvrL2hBX 3urA== X-Gm-Message-State: AHYfb5gDTdm294+6YKChMlV0ilVE2g9AJ5/e474BBJqy3dIR5uAlRXHD yqDRUE46Ekp12Q== X-Received: by 10.223.177.133 with SMTP id q5mr177372wra.135.1503919625207; Mon, 28 Aug 2017 04:27:05 -0700 (PDT) Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162]) by smtp.gmail.com with ESMTPSA id q13sm223032wrg.55.2017.08.28.04.27.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Aug 2017 04:27:04 -0700 (PDT) From: Mark Walters To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] emacs: maildir fcc make insert more flexible In-Reply-To: References: <1503905542-19961-1-git-send-email-markwalters1009@gmail.com> <1503905542-19961-2-git-send-email-markwalters1009@gmail.com> Date: Mon, 28 Aug 2017 12:27:03 +0100 Message-ID: <87r2vworug.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 11:27:08 -0000 Hi Thanks for the review. On Mon, 28 Aug 2017, David Edmondson wrote: > On Monday, 2017-08-28 at 08:32:21 +0100, Mark Walters wrote: > >> This changeset makes the function >> notmuch-maildir-fcc-with-notmuch-insert slightly more flexible by >> allowing some of the prompts to be controlled by the caller. >> --- >> emacs/notmuch-maildir-fcc.el | 16 ++++++++++------ >> 1 file changed, 10 insertions(+), 6 deletions(-) >> >> diff --git a/emacs/notmuch-maildir-fcc.el b/emacs/notmuch-maildir-fcc.el >> index 1551e8b..acff24d 100644 >> --- a/emacs/notmuch-maildir-fcc.el >> +++ b/emacs/notmuch-maildir-fcc.el >> @@ -227,7 +227,7 @@ should be a list of tag changes to apply to the inse= rted message." >> (apply 'notmuch-call-notmuch-process >> :stdin-string (buffer-string) "insert" args))) >>=20=20 >> -(defun notmuch-maildir-fcc-with-notmuch-insert (fcc-header &optional cr= eate) >> +(defun notmuch-maildir-fcc-with-notmuch-insert (fcc-header &optional cr= eate header-name) > > Given that this is not FCC specific, perhaps rename it? Yes that might make sense. > >> "Store message with notmuch insert. >>=20=20 >> The fcc-header should be of the form \"folder +tag1 -tag2\" where > > I realise that this patch set didn't add this string, but it is mildly > ridiculous. There's no reason that we couldn't use a list, where a > leading =E2=80=9C+=E2=80=9D or =E2=80=9C-=E2=80=9D indicates a tag and an= ything else is a folder. > > Even two variables (one for folder and another for tags) would be an > improvement The reason for this choice is that, when writing the postpone code, I wanted to keep within the message mode compose world, which has the fcc header as a string. I think I would also only like to be queried once when inserting. Or are you suggesting that the user types in a lisp list? Best wishes Mark