From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 252326DE0191 for ; Sat, 11 Nov 2017 15:14:11 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -1.357 X-Spam-Level: X-Spam-Status: No, score=-1.357 tagged_above=-999 required=5 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_SOFTFAIL=0.972, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tgb4XU9qmLpO for ; Sat, 11 Nov 2017 15:14:09 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by arlo.cworth.org (Postfix) with ESMTPS id C79AD6DE0173 for ; Sat, 11 Nov 2017 15:14:09 -0800 (PST) Received: from smtp01.caltech.edu (localhost [127.0.0.1]) by smtp01.caltech.edu (Postfix) with ESMTP id 88F0FA14C4; Sat, 11 Nov 2017 15:14:07 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on smtp01.caltech.edu by amavisd-new Received: from finestructure.net (ip184-180-110-103.br.br.cox.net [184.180.110.103]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jrollins) by smtp-server.its.caltech.edu (Postfix) with ESMTPSA id DAD61A13DF; Sat, 11 Nov 2017 15:14:06 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id 0C02860317; Sat, 11 Nov 2017 15:14:06 -0800 (PST) From: Jameson Graef Rollins To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 07/18] crypto: new decryption policy "auto" In-Reply-To: <20171025065203.24403-8-dkg@fifthhorseman.net> References: <20171025065203.24403-1-dkg@fifthhorseman.net> <20171025065203.24403-8-dkg@fifthhorseman.net> User-Agent: Notmuch/0.25.1 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-pc-linux-gnu) Date: Sat, 11 Nov 2017 15:14:03 -0800 Message-ID: <87r2t4s91g.fsf@ligo.caltech.edu> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Nov 2017 23:14:11 -0000 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, Oct 25 2017, Daniel Kahn Gillmor wrote: > diff --git a/util/crypto.h b/util/crypto.h > index b23ca747..dc95b4ca 100644 > --- a/util/crypto.h > +++ b/util/crypto.h > @@ -16,7 +16,8 @@ typedef struct _notmuch_crypto { > } _notmuch_crypto_t; >=20=20 > GMimeObject * > -_notmuch_crypto_decrypt (notmuch_message_t *message, > +_notmuch_crypto_decrypt (notmuch_decryption_policy_t decrypt, > + notmuch_message_t *message, > GMimeCryptoContext* crypto_ctx, > GMimeMultipartEncrypted *part, > GMimeDecryptResult **decrypt_result, Why does _notmuch_crypt_decrypt need to have "notmuch_decryption_policy_t decrypt" as an input argument? Isn't notmuch_decryption_policy_t already an attribute of the crypto_ctx? Is there some situation where the policy would differ from what's specified in the crypto_ctx? jamie. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEtl0IW5QRe4ExYLZZ7TTOq+J7qrwFAloHhDsACgkQ7TTOq+J7 qrwWEBAAtWlyKHeFy+IUmVEG70ejJemUpzNgK7pyI7iCoM0xvVY9omswSldFphqF CluCRw6XJrly4Lv7Zly0nXZlfAPMSxXc6P7Xk6zWpremWanHbQINuL+3dqjRMQhQ J7sQOvM/pmH83U4pEi9HK1LtSjDQzMXzk84ulKuayq/8evZHY2zYp0hq/PjyC98n FKOEi3gTw9Gtjp8LdUkTawK+MhJ72e363KbmBwUS5vqEZhYjWc/DgsqTYbx09W6+ edaNtdaX1Oc24X5K9wvFJAiNTSElLYJElLUovkiZKSZvQllKE8BIaVktAIFPpR2H EZ2/EApdENaL33XCtRg5daVKYWcGhMRMyTxyvuaO8eVGmhJSRAkgvySm4GIqLIrY KqirPT7IPgZQOZ1EX/I4BS9tgmQ7eRBmRlZx3FHX7sJ4gLTm8xfpoOm6fMMU4wgi oow4FnhEH3mzZ9PkdjaO7QAjFIdPmWI4yrY5gI+hPX+0++VQnEuhD/YYBdUbmaOg QR6eOk4Ohz7RNIbg+jvt5zPkG/dJ5Dvy1dZFeSvIfB9iqIMwyiNcjYgNvsgXH2zm rEOwrbVc8bex8RvTH9kVKNbeHHvts7RfoohX6aAP2F7YYEGKJ0xdPymzWCkvR+Lg 7t3v1xSo+08qHcjqPCTrlJ+W3ECjwd7Qaqh3V0y0wN6VKqru5fE= =cePh -----END PGP SIGNATURE----- --=-=-=--