From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A40EB6DE0B78 for ; Thu, 30 Nov 2017 07:58:40 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.01 X-Spam-Level: X-Spam-Status: No, score=-0.01 tagged_above=-999 required=5 tests=[AWL=-0.010] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yy6_4ch-DP6z for ; Thu, 30 Nov 2017 07:58:38 -0800 (PST) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTPS id 17E056DE0222 for ; Thu, 30 Nov 2017 07:58:37 -0800 (PST) Received: from fifthhorseman.net (ool-6c3a0662.static.optonline.net [108.58.6.98]) by che.mayfirst.org (Postfix) with ESMTPSA id 863E5F99A; Thu, 30 Nov 2017 10:58:36 -0500 (EST) Received: by fifthhorseman.net (Postfix, from userid 1000) id 5587220744; Thu, 30 Nov 2017 10:58:33 -0500 (EST) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH 18/18] python: add try_decrypt argument to Database.index_file() In-Reply-To: <87o9o28jb2.fsf@tethera.net> References: <20171025065203.24403-1-dkg@fifthhorseman.net> <20171025065203.24403-19-dkg@fifthhorseman.net> <87o9o28jb2.fsf@tethera.net> Date: Thu, 30 Nov 2017 10:58:33 -0500 Message-ID: <87r2sf3gie.fsf@fifthhorseman.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 15:58:40 -0000 On Thu 2017-11-16 09:06:09 -0400, David Bremner wrote: > I think this new bindings functionality needs a test. agreed, the python bindings do need to be added to the test suite (this is also true in the newer version of the series). I'm happy to add those tests as a condition of getting the python bindings merged, but i hope they won't block the review and merge of the rest of the series :) --dkg