From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 4DCE46DE0B14 for ; Fri, 8 Dec 2017 10:36:13 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wPU81s6Q0Y9S for ; Fri, 8 Dec 2017 10:36:12 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 2A2536DE02DA for ; Fri, 8 Dec 2017 10:36:12 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1eNNVH-0007si-57; Fri, 08 Dec 2017 13:36:07 -0500 Received: (nullmailer pid 4508 invoked by uid 1000); Fri, 08 Dec 2017 18:36:04 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH] crypto: signature verification reports valid User IDs In-Reply-To: <20171130042035.9502-1-dkg@fifthhorseman.net> References: <20171130042035.9502-1-dkg@fifthhorseman.net> Date: Fri, 08 Dec 2017 14:36:04 -0400 Message-ID: <87r2s5dq3v.fsf@tesseract.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 18:36:13 -0000 Daniel Kahn Gillmor writes: > @@ -478,9 +478,10 @@ fi > # we need to have a version >= 2.6.5 to avoid a crypto bug. We need > # 2.6.7 for permissive "From " header handling. > GMIME_MINVER=2.6.7 > +GMIME3_MINVER=3.0.3 Does this change mean notmuch won't build at all for people with gmime-3 < 3.0.3? I understand that's not a problem in Debian, but what about in general? > > + > +static const char* > +_get_certificate_valid_userid (GMimeCertificate *cert) > +{ Since we already have util/gmime-extra.c to deal with differences between gmime-3.0 and 2.6, and since this code is purely gmime related (not using any notmuch data or types), it makes sense to me put this (split) there. I guess we might use a different prefix for stuff we add, although iirc we didn't bother for zlib-extra.c d