From: David Bremner <david@tethera.net>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] crypto: signature verification reports valid User IDs
Date: Fri, 08 Dec 2017 14:36:04 -0400 [thread overview]
Message-ID: <87r2s5dq3v.fsf@tesseract.cs.unb.ca> (raw)
In-Reply-To: <20171130042035.9502-1-dkg@fifthhorseman.net>
Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
> @@ -478,9 +478,10 @@ fi
> # we need to have a version >= 2.6.5 to avoid a crypto bug. We need
> # 2.6.7 for permissive "From " header handling.
> GMIME_MINVER=2.6.7
> +GMIME3_MINVER=3.0.3
Does this change mean notmuch won't build at all for people with gmime-3
< 3.0.3? I understand that's not a problem in Debian, but what about in
general?
>
> +
> +static const char*
> +_get_certificate_valid_userid (GMimeCertificate *cert)
> +{
Since we already have util/gmime-extra.c to deal with differences
between gmime-3.0 and 2.6, and since this code is purely gmime related
(not using any notmuch data or types), it makes sense to me put this
(split) there. I guess we might use a different prefix for stuff we add,
although iirc we didn't bother for zlib-extra.c
d
next prev parent reply other threads:[~2017-12-08 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 4:20 [PATCH] crypto: signature verification reports valid User IDs Daniel Kahn Gillmor
2017-12-08 6:38 ` Daniel Kahn Gillmor
2017-12-08 18:36 ` David Bremner [this message]
2017-12-08 18:55 ` Daniel Kahn Gillmor
2017-12-08 18:55 ` [PATCH v2] " Daniel Kahn Gillmor
2017-12-08 20:09 ` v3 of fixing signature verification Daniel Kahn Gillmor
2017-12-08 20:09 ` [PATCH v3] crypto: signature verification reports valid User IDs Daniel Kahn Gillmor
2017-12-09 2:26 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2s5dq3v.fsf@tesseract.cs.unb.ca \
--to=david@tethera.net \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).