From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 195016DE025F
 for <notmuch@notmuchmail.org>; Thu, 10 May 2018 13:57:26 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[AWL=0.011,
 SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id BpY0C9JM3ibA for <notmuch@notmuchmail.org>;
 Thu, 10 May 2018 13:57:25 -0700 (PDT)
Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
 by arlo.cworth.org (Postfix) with ESMTPS id 0F4706DE025A
 for <notmuch@notmuchmail.org>; Thu, 10 May 2018 13:57:24 -0700 (PDT)
Received: from remotemail by fethera.tethera.net with local (Exim 4.89)
 (envelope-from <david@tethera.net>)
 id 1fGscq-0001o2-4F; Thu, 10 May 2018 16:57:20 -0400
Received: (nullmailer pid 21932 invoked by uid 1000);
 Thu, 10 May 2018 20:57:18 -0000
From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, Prof Jayanth R Varma <jrvarma@gmail.com>,
 notmuch@notmuchmail.org
Subject: Re: emacs: Split wide window vertically for tree mode message pane
In-Reply-To: <m21sejtf1i.fsf@guru.guru-group.fi>
References: <877eszb8bo.fsf@JRVARMAPC.i-did-not-set--mail-host-address--so-tickle-me>
 <871sekblh8.fsf@tethera.net> <m21sejtf1i.fsf@guru.guru-group.fi>
Date: Thu, 10 May 2018 17:57:18 -0300
Message-ID: <87r2mjb55d.fsf@tethera.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 10 May 2018 20:57:26 -0000

Tomi Ollila <tomi.ollila@iki.fi> writes:

> On Wed, May 09 2018, David Bremner wrote:
>
>> Prof Jayanth R Varma <jrvarma@gmail.com> writes:
>>
>>> This patch modifies the function notmuch-tree-show-message-in in 
>>> notmuch-tree.el to split the window vertically while creating a 
>>> message pane in tree-mode if the window is wider than 160 (so that 
>>> after splitting, the message pane can show the standard 76 
>>> character plain text email lines without wrapping).
>>
>> First, I'm sorry to take so long to review this.  A few comments.
>>
>> 1) I'm reluctant to add new features to notmuch without corresponding
>>    tests. Currently all of our emacs tests use a standard terminal width
>>    (I think 80). Perhaps Tomi knows how hard it would be to override for
>>    a single test.

>
> That would be pretty simple; we'd add variable for colums to be set before
> test... buf for this particular case I don't know how there could be any
> sensible test done 

I was thinking basically the tests with output in
emacs-tree.expected-output, with the other split.

d