[PATCH] configure: fix mktemp call for macOS

[PATCH] configure: fix mktemp call for macOS

[Ralph Seichter]

The mktemp call in configure is incompatible with /usr/bin/mktemp as
shipped with macOS, where it fails due to a missing parameter. I added
the missing template, and the call is now working with both Apple's
and GNU coreutils' mktemp.

Signed-off-by: Ralph Seichter <abbot@monksofcool.net>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 8b80f0e0..feebafcc 100755
--- a/configure
+++ b/configure
@@ -529,7 +529,7 @@ int main () {
     return 0;
 }
 EOF
-    if ! TEMP_GPG=$(mktemp -d); then
+    if ! TEMP_GPG=$(mktemp -d /tmp/notmuch.XXXXXX); then
         printf 'No.\nCould not make tempdir for testing session-key support.\n'
         errors=$((errors + 1))
     elif ${CC} ${CFLAGS} ${gmime_cflags} _check_session_keys.c ${gmime_ldflags} -o _check_session_keys \
-- 
2.21.0

Re: [PATCH] configure: fix mktemp call for macOS

[David Bremner]

Ralph Seichter <abbot@monksofcool.net> writes:

> The mktemp call in configure is incompatible with /usr/bin/mktemp as
> shipped with macOS, where it fails due to a missing parameter. I added
> the missing template, and the call is now working with both Apple's
> and GNU coreutils' mktemp.
>

I'm hoping Tomi will comment, but I wonder if we should do something
like

TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")

(borrowed from test/test-lib.sh). This avoids hardcoding the temporary
directory.

Re: [PATCH] configure: fix mktemp call for macOS

[Ralph Seichter]

* David Bremner:

> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>
> (borrowed from test/test-lib.sh). This avoids hardcoding the temporary
> directory.

I had the same thought at first, but I want to ensure that the path
length does not cause trouble anymore.

  > uname -v
  Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64
  > echo $TMPDIR
  /var/folders/m_/w5lk3r_1495dhnl4l0s96pr00000gn/T/

That's my MacBook Pro with macOS 10.14.5 (Mojave). AFAIK, older versions
can have longer names. Also, I am concerned with accumulating clutter.

  > grep clean_tmps_dirs /etc/defaults/periodic.conf
  daily_clean_tmps_dirs="/tmp"

The /tmp directory will, with default settings, be cleaned periodically
by the OS, while $TMPDIR (which is user-specific) will not.

-Ralph

Re: [PATCH] configure: fix mktemp call for macOS

[Tomi Ollila]

On Fri, Jun 14 2019, Ralph Seichter wrote:

> * David Bremner:
>
>> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>>
>> (borrowed from test/test-lib.sh). This avoids hardcoding the temporary
>> directory.
>
> I had the same thought at first, but I want to ensure that the path
> length does not cause trouble anymore.

Yes. $TMPDIR could be problematic if it makes the full (unix domain
socket?) path be too long.

SO, exact version Ralph made looks good to me.

Tomi


>
>   > uname -v
>   Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64
>   > echo $TMPDIR
>   /var/folders/m_/w5lk3r_1495dhnl4l0s96pr00000gn/T/
>
> That's my MacBook Pro with macOS 10.14.5 (Mojave). AFAIK, older versions
> can have longer names. Also, I am concerned with accumulating clutter.
>
>   > grep clean_tmps_dirs /etc/defaults/periodic.conf
>   daily_clean_tmps_dirs="/tmp"
>
> The /tmp directory will, with default settings, be cleaned periodically
> by the OS, while $TMPDIR (which is user-specific) will not.
>
> -Ralph
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] configure: fix mktemp call for macOS

[Tomi Ollila]

On Fri, Jun 14 2019, Tomi Ollila wrote:

> On Fri, Jun 14 2019, Ralph Seichter wrote:
>
>> * David Bremner:
>>
>>> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>>>
>>> (borrowed from test/test-lib.sh). This avoids hardcoding the temporary
>>> directory.
>>
>> I had the same thought at first, but I want to ensure that the path
>> length does not cause trouble anymore.
>
> Yes. $TMPDIR could be problematic if it makes the full (unix domain
> socket?) path be too long.
>
> SO, exact version Ralph made looks good to me.


Revert that. mktemp(1) uses $TMPDIR if defined (and just tested)

>
> Tomi
>
>
>>
>>   > uname -v
>>   Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64
>>   > echo $TMPDIR
>>   /var/folders/m_/w5lk3r_1495dhnl4l0s96pr00000gn/T/
>>
>> That's my MacBook Pro with macOS 10.14.5 (Mojave). AFAIK, older versions
>> can have longer names. Also, I am concerned with accumulating clutter.
>>
>>   > grep clean_tmps_dirs /etc/defaults/periodic.conf
>>   daily_clean_tmps_dirs="/tmp"
>>
>> The /tmp directory will, with default settings, be cleaned periodically
>> by the OS, while $TMPDIR (which is user-specific) will not.
>>
>> -Ralph
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] configure: fix mktemp call for macOS

[Daniel Kahn Gillmor]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

On Fri 2019-06-14 20:57:07 +0300, Tomi Ollila wrote:

> Yes. $TMPDIR could be problematic if it makes the full (unix domain
> socket?) path be too long.

Modern, maintained version of GnuPG will only place sockets directly in
the $GNUPGHOME if /run/user/$(id -u) (i.e., $XDG_RUNTIME_DIR) is not
available.

I've just sent a message to gnupg-devel asking for help from upstream
there, this shouldn't be this complicated.  see
id:87blyxd2qu.fsf@fifthhorseman.net on gnupg-devel@gnupg.org ("safe
ephemeral GnuPG homdirs").

          --dkg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

Fwd: Delivery Status Notification (Failure)

[Tomi Ollila]

[-- Attachment #1.1: Type: text/plain, Size: 2246 bytes --]

Sorry for the mess -- too tired to fight with this -- hopefully the content
is readable below (will not know before mail leaves...)

[image: Virhekuvake]
Viestiä ei toimitettu
Olet lähettämässä viestiä toisesta osoitteesta tai aliaksesta
Lähetysosoite-ominaisuudella. Lähetysosoite-tilin asetukset ovat
virheelliset tai vanhentuneet. Tarkista kyseisen tilin asetukset ja yritä
lähettää viesti uudelleen.
LISÄTIETOJA <https://support.google.com/mail/?p=CustomFromDenied>




---------- Forwarded message ----------
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Cc:
Bcc:
Date: Fri, 14 Jun 2019 23:11:47 +0300
Subject: Re: [PATCH] configure: fix mktemp call for macOS
Hi

cannot (easily) attach to the thread from this account, therefore...

First, it would be better if

TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")

worked, then the behaviour on Linux would not change.


To me it looks like the problem in that one debian bug (i847206) is that the
directory pathname is already like 106 octets -- and on Linux the maximun
unix domain socket pathname is 108 octets -- gpg socket is probably longer
than 1 octet here :D

In case of macOS (and BSD, so says internet) max pathname is 104 octets

In Ralph's example $TMPDIR is

/var/folders/m_/w5lk3r_1495dhnl4l0s96pr00000gn/T/

-- 50 octets. Also probably older system would not have so much longer
tmpdir settings that appending gpg socket name would make length pass
104 octets...

But I am not personally against "hardcoding" /tmp/ (i.e. ignoring TMPDIR) as
prefix location where temporary directory for GNUPGHOME is created
(and, again I don't see where it could fail (barring cases similar to xkcd
 workflow)), but perhaps the behavioural change could be mentioned in
the commit message.

(BTW: in case of clutter, by default $TMPDIR is not set, and if set then
user is
responsible of cleaning the clutter. if macOS does its own magic with
$TMPDIR (i.e. w/o user's intervention) then os should also take care
of the clutter...)

(BTW2: I was about to claim that ./configure in notmuch removes GNUPGHOME
 quickly after its use has ended, but I did not look anything doing that...)


Tomi

[-- Attachment #1.2: Type: text/html, Size: 3811 bytes --]

[-- Attachment #2: icon.png --]
[-- Type: image/png, Size: 5747 bytes --]

Re: [PATCH] configure: fix mktemp call for macOS

[Ralph Seichter]

* Tomi Ollila:

> First, it would be better if
>
> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>
> worked, then the behaviour on Linux would not change.

I'm trying to figure out if I can override $TMPDIR during the MacPorts
configure phase. According to the documentation, modifying environment
variables should work, but I am not quite there yet.

Corollary: I suggest we go for the method shown above for the time
being. I am not a fan of hardcoding paths either.

-Ralph

Re: [PATCH] configure: fix mktemp call for macOS

[Tomi Ollila]

On Sat, Jun 15 2019, Ralph Seichter wrote:

> * Tomi Ollila:
>
>> First, it would be better if
>>
>> TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX")
>>
>> worked, then the behaviour on Linux would not change.
>
> I'm trying to figure out if I can override $TMPDIR during the MacPorts
> configure phase. According to the documentation, modifying environment
> variables should work, but I am not quite there yet.
>
> Corollary: I suggest we go for the method shown above for the time
> being. I am not a fan of hardcoding paths either.

That maintains the status quo, so no-one needs to explain the change
in commit message.

SO I pre-LGTM anyone sending message containing the followin change:

+    if ! TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX"); then

Tomi


>
> -Ralph

[PATCH] configure: fix mktemp call for macOS

[Ralph Seichter]

Add missing template to mktemp, as required by macOS / OS X.

Signed-off-by: Ralph Seichter <abbot@monksofcool.net>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 8b80f0e0..6e73b22e 100755
--- a/configure
+++ b/configure
@@ -529,7 +529,7 @@ int main () {
     return 0;
 }
 EOF
-    if ! TEMP_GPG=$(mktemp -d); then
+    if ! TEMP_GPG=$(mktemp -d "${TMPDIR:-/tmp}/notmuch.XXXXXX"); then
         printf 'No.\nCould not make tempdir for testing session-key support.\n'
         errors=$((errors + 1))
     elif ${CC} ${CFLAGS} ${gmime_cflags} _check_session_keys.c ${gmime_ldflags} -o _check_session_keys \
-- 
2.22.0

(This obsoletes id:87r27z63uk.fsf@ra.horus-it.com)

Re: [PATCH] configure: fix mktemp call for macOS

[David Bremner]

Ralph Seichter <abbot@monksofcool.net> writes:

> Add missing template to mktemp, as required by macOS / OS X.
>
> Signed-off-by: Ralph Seichter <abbot@monksofcool.net>
> ---

I've merged this to master and release. In the case that we do another
point release before 0.30, it will be in that.

d