From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 22AF26DE0C5F for ; Mon, 18 Nov 2019 13:27:54 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.203 X-Spam-Level: X-Spam-Status: No, score=-0.203 tagged_above=-999 required=5 tests=[AWL=-0.352, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O99Dt67jzE4E for ; Mon, 18 Nov 2019 13:27:49 -0800 (PST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by arlo.cworth.org (Postfix) with ESMTPS id AE4F56DE0C4A for ; Mon, 18 Nov 2019 13:27:49 -0800 (PST) Received: by mail-wm1-f68.google.com with SMTP id a17so865139wmb.0 for ; Mon, 18 Nov 2019 13:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:in-reply-to:references:date:message-id :mime-version; bh=ymMsCIKGTEhruIRvBNvjjrKzbvMLLrgWsNuK9x9bmeQ=; b=cxn6rxaoX6QhxFUrWll3AYrz6pN5oGi//Acj899kfoWALukJEsvmiSjjUDVvvp3cRL cxsPgUs19jo2iObZVJZKsmmEVQTInojrIaxbzgec/T4SI4ZxS2aO4mWAnY9C3QJ5pKx8 aMSobhibBc0xgmihv1tlCtyRUAuxxiuTlfHGN6qnvOt9+hiqnlVGZ+0C43PJ/7PD++vq EdOhirilCAxnRpxvMbpFsvBHn2pPpp2Cuc7V8XL4S4M+GrumOqOOOFTewKM2qCx7fvSa T1nTdwpgF0xQpI21Acfw87bXsW0MXXsVfEl0iGBz3nEijvBQRz3dZL9mta8uuxsoqf/V 9CCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:in-reply-to:references :date:message-id:mime-version; bh=ymMsCIKGTEhruIRvBNvjjrKzbvMLLrgWsNuK9x9bmeQ=; b=c4swtGfSv9neOtZqo27s2uvJMy+rOkbzbFdpdw7rK+R8nyLJYZz1OLl2MWZUjQe416 wyTkypw+jvb4oGIyb4j4+5uFBi1c3H6d7Olb2pSJuxZtqOyDlPY9/k3a2QlyOpvHPvKp 0jSbjbFxSo0cDLV6fgwPLmSZg7qcTfWVATZOduAnbsWGKr8Tq/rBtvwPzzHZkJPZOBy6 wjXZsJrJf36gwKPMAZBNQB4x/NBYrJxGroRBnQAy3WKarEe6ouAJQ+bco9G4sz4Npwjp fb289ndxm8+wKTgOg2ACbqngc/Iwvo7hCVbd5XCRl8fQ1KHkfjZKooAOa+uymNbRo4Xp vorg== X-Gm-Message-State: APjAAAVjSIUyrOyd7VooIo45aD4s6PhBVv20XDLFglGwvBR3zZ8mthVn YfYCMRJSdncFsj6Bi6ZHx50= X-Google-Smtp-Source: APXvYqyK35i4xsjJruDZgWOtDmPYSkoMBP1IzY8ACcm81CV3LAuI+6gxjxhnz8U5dj0ANSaSdtfjvg== X-Received: by 2002:a1c:6745:: with SMTP id b66mr1574918wmc.30.1574112466481; Mon, 18 Nov 2019 13:27:46 -0800 (PST) Received: from powell.devork.be ([2a02:168:58d0::7a3]) by smtp.gmail.com with ESMTPSA id v6sm25190916wrt.13.2019.11.18.13.27.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 13:27:45 -0800 (PST) Sender: Floris Bruynooghe Received: (nullmailer pid 291581 invoked by uid 1000); Mon, 18 Nov 2019 21:27:43 -0000 From: Floris Bruynooghe To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] Show which notmuch command and version is being used In-Reply-To: <877e3xcsvm.fsf@tethera.net> References: <20191117164135.220969-1-flub@devork.be> <20191117164135.220969-2-flub@devork.be> <877e3xcsvm.fsf@tethera.net> Date: Mon, 18 Nov 2019 22:27:43 +0100 Message-ID: <87r224q3hs.fsf@powell.devork.be> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Nov 2019 21:27:54 -0000 On Mon 18 Nov 2019 at 07:43 -0400, David Bremner wrote: > Floris Bruynooghe writes: > >> This add the notmuch version and absolute path of the binary used >> in the pytest header. This is nice when running the tests >> interactively as you get confirmation you're testing the version you >> thought you were testing. >> --- >> bindings/python-cffi/tests/conftest.py | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/bindings/python-cffi/tests/conftest.py b/bindings/python-cffi/tests/conftest.py >> index aa940947..674c7218 100644 >> --- a/bindings/python-cffi/tests/conftest.py >> +++ b/bindings/python-cffi/tests/conftest.py >> @@ -10,6 +10,13 @@ import os >> import pytest >> >> >> +def pytest_report_header(): >> + vers = subprocess.run(['notmuch', '--version'], stdout=subprocess.PIPE) >> + which = subprocess.run(['which', 'notmuch'], stdout=subprocess.PIPE) > > I think it would be better to use "shutil.which()" here, to avoid > variations in shell builtin vs executable which. If you agree I can make > the change. Oh nice, I always forget about shutil. Please do make the change. Thanks, Floris