From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id uJq7CuHAN18qHQAA0tVLHw (envelope-from ) for ; Sat, 15 Aug 2020 11:02:57 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id kGODBuHAN19cKAAA1q6Kng (envelope-from ) for ; Sat, 15 Aug 2020 11:02:57 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5D8B0940776 for ; Sat, 15 Aug 2020 11:02:55 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id F168B29B96; Sat, 15 Aug 2020 07:02:47 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 113AC2711E for ; Sat, 15 Aug 2020 07:02:45 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 1912D5FDE2; Sat, 15 Aug 2020 07:02:41 -0400 (EDT) Received: (nullmailer pid 66725 invoked by uid 1000); Sat, 15 Aug 2020 11:02:39 -0000 From: David Bremner To: Sean Whitton , notmuch@notmuchmail.org Subject: Re: [PATCH v2] emacs: Use pop-to-buffer-same-window rather than switch-to-buffer In-Reply-To: <20200811165913.4459-1-spwhitton@spwhitton.name> References: <20200811165913.4459-1-spwhitton@spwhitton.name> Date: Sat, 15 Aug 2020 08:02:39 -0300 Message-ID: <87r1s85fzk.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 5CHVJ5XGZRZWPWW5JOXGULA3UL4EUOYU X-Message-ID-Hash: 5CHVJ5XGZRZWPWW5JOXGULA3UL4EUOYU X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.53 X-TUID: mzFR9wogx6+j Sean Whitton writes: > This means that notmuch commands obey display-buffer-alist so the user > can customize how buffers show up. > > It also permits the use of C-x 4 4, C-x 5 5 and C-x t t, available in > Emacs 28. For example, one can use C-x 4 4 M-x notmuch-jump-search RET > to open a saved search in another window rather than the current window. > Or in notmuch-search mode, C-x 5 5 RET to view the message at point in > a new frame. > > notmuch-tree has custom buffer display logic, so bind > display-buffer-overriding-action to make pop-to-buffer-same-window > behave exactly as switch-to-buffer while that function is running. I only tested this in emacs 26.3, but I think I hit all the modified code paths and it didn't crash. It would be nice to have one or two more people try it out before I apply to master; I tend to be somewhat oblivious to subtle changes in emacs window behaviour. d