* [PATCH] Fix database instructions in test/README: make download-corpus
@ 2020-08-15 10:51 Teemu Likonen
2020-08-15 12:15 ` [PATCH] test: update README to reflect dropping upgrade tests David Bremner
0 siblings, 1 reply; 3+ messages in thread
From: Teemu Likonen @ 2020-08-15 10:51 UTC (permalink / raw)
To: notmuch
---
test/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Currently test/README file instructs user to download database files
with command:
make download-test-databases
That doesn't work for me. I got tests running after executing "make
download-corpus" instead. So maybe that's the correct Makefile target.
If so, this patch should go in.
diff --git a/test/README b/test/README
index 3f54af58..d2a1fdb3 100644
--- a/test/README
+++ b/test/README
@@ -82,7 +82,7 @@ The following command-line options are available when running tests:
Certain tests require precomputed databases to complete. You can fetch these
databases with
- make download-test-databases
+ make download-corpus
If you do not download the test databases, the relevant tests will be
skipped.
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] test: update README to reflect dropping upgrade tests
2020-08-15 10:51 [PATCH] Fix database instructions in test/README: make download-corpus Teemu Likonen
@ 2020-08-15 12:15 ` David Bremner
2020-08-16 13:55 ` David Bremner
0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2020-08-15 12:15 UTC (permalink / raw)
To: Teemu Likonen, notmuch; +Cc: David Bremner
These test databases have been unneeded since ee897cab8.
---
You're correct that the README needs updating, but download-corpus is
for the performance tests.
test/README | 8 --------
1 file changed, 8 deletions(-)
diff --git a/test/README b/test/README
index 3f54af58..11eaf18f 100644
--- a/test/README
+++ b/test/README
@@ -79,14 +79,6 @@ The following command-line options are available when running tests:
As the names depend on the tests' file names, it is safe to
run the tests with this option in parallel.
-Certain tests require precomputed databases to complete. You can fetch these
-databases with
-
- make download-test-databases
-
-If you do not download the test databases, the relevant tests will be
-skipped.
-
When invoking the test suite via "make test" any of the above options
can be specified as follows:
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-16 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-15 10:51 [PATCH] Fix database instructions in test/README: make download-corpus Teemu Likonen
2020-08-15 12:15 ` [PATCH] test: update README to reflect dropping upgrade tests David Bremner
2020-08-16 13:55 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).