From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6HL2CPpSrF9lOAAA0tVLHw (envelope-from ) for ; Wed, 11 Nov 2020 21:09:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id qE/lBPpSrF8IZgAAbx9fmQ (envelope-from ) for ; Wed, 11 Nov 2020 21:09:14 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8589D940981 for ; Wed, 11 Nov 2020 21:09:11 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B198528C0F; Wed, 11 Nov 2020 16:09:04 -0500 (EST) Received: from jb55.com (jb55.com [IPv6:2600:3c01::f03c:91ff:fe08:5bfb]) by mail.notmuchmail.org (Postfix) with ESMTPS id 771AF1F9E9 for ; Wed, 11 Nov 2020 16:09:01 -0500 (EST) Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187]) by jb55.com (OpenSMTPD) with ESMTPSA id acd81a9c (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 11 Nov 2020 21:09:46 +0000 (UTC) From: William Casarin To: Jonas Bernoulli , notmuch@notmuchmail.org Cc: David Bremner , Carl Worth Subject: Re: [PATCH 04/27] emacs: don't fset keymaps In-Reply-To: <20201108190311.1397-5-jonas@bernoul.li> References: <20201108190311.1397-1-jonas@bernoul.li> <20201108190311.1397-5-jonas@bernoul.li> Date: Wed, 11 Nov 2020 13:08:58 -0800 Message-ID: <87r1ozzjmd.fsf@jb55.com> MIME-Version: 1.0 Message-ID-Hash: PGDIH4ESXP2IK5BSGGIJXVZ2GOVVNNHB X-Message-ID-Hash: PGDIH4ESXP2IK5BSGGIJXVZ2GOVVNNHB X-MailFrom: jb55@jb55.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: -1.01 X-TUID: SeO+dmaEz0R4 Jonas Bernoulli writes: > These keymaps are never invoked as commands > so the function definitions serve no purpose. > --- > emacs/notmuch-show.el | 1 - > emacs/notmuch-tree.el | 1 - > emacs/notmuch.el | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el > index b08ceb97..ec22fd94 100644 > --- a/emacs/notmuch-show.el > +++ b/emacs/notmuch-show.el > @@ -1485,7 +1485,6 @@ (defvar notmuch-show-mode-map > (define-key map "B" 'notmuch-show-browse-urls) > map) > "Keymap for \"notmuch show\" buffers.") > -(fset 'notmuch-show-mode-map notmuch-show-mode-map) > > (define-derived-mode notmuch-show-mode fundamental-mode "notmuch-show" > "Major mode for viewing a thread with notmuch. > diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el > index ea6a5cf3..ad08f7c6 100644 > --- a/emacs/notmuch-tree.el > +++ b/emacs/notmuch-tree.el > @@ -361,7 +361,6 @@ (defvar notmuch-tree-mode-map > (define-key map "e" 'notmuch-tree-resume-message) > map) > "Keymap for \"notmuch tree\" buffers.") > -(fset 'notmuch-tree-mode-map notmuch-tree-mode-map) > > (defun notmuch-tree-get-message-properties () > "Return the properties of the current message as a plist. > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > index 83bcee57..165aaa43 100644 > --- a/emacs/notmuch.el > +++ b/emacs/notmuch.el > @@ -194,7 +194,6 @@ (defvar notmuch-search-mode-map > (define-key map "U" 'notmuch-unthreaded-from-search-current-query) > map) > "Keymap for \"notmuch search\" buffers.") > -(fset 'notmuch-search-mode-map notmuch-search-mode-map) > > (defvar notmuch-search-stash-map > (let ((map (make-sparse-keymap))) > -- > 2.29.1 I believe this makes sense. Looks like they were first introduced in early versions of the code... Reviewed-by: William Casarin Tested-by: William Casarin