From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id QOaaB0GO+19JEQAA0tVLHw (envelope-from ) for ; Sun, 10 Jan 2021 23:31:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GJdmA0GO+1/eegAAB5/wlQ (envelope-from ) for ; Sun, 10 Jan 2021 23:31:13 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8D00F9402D6 for ; Sun, 10 Jan 2021 23:31:11 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 00CB929D2C; Sun, 10 Jan 2021 18:31:06 -0500 (EST) Received: from mail.hostpark.net (mail.hostpark.net [212.243.197.30]) by mail.notmuchmail.org (Postfix) with ESMTPS id 03A8729D05 for ; Sun, 10 Jan 2021 18:31:02 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id BE8FE160DD; Sun, 10 Jan 2021 21:47:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1610311641; bh=ZlB4fqnHkc8uP0kK2QFqWONg JLh7cvhMFNXYO2VYxcM=; b=y/iyLIPO+76InS5ux2p/zFNmRuxowNr0H1473hp5 Bsa58dTr83NQTFrVMrbVUEpfD/CXuGWkO9BeJZ7DrYvb03pgUqlxTU19FC+I8YxX PPxrFzQZN5AWrRSQe1kZU6mFJNe3U0SGnucl0qp9tt7zcjwSe6IbuyjljlNErOCf 0ks= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id iuipbhsoRHnV; Sun, 10 Jan 2021 21:47:21 +0100 (CET) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 8DC5E160BA; Sun, 10 Jan 2021 21:47:21 +0100 (CET) From: Jonas Bernoulli To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 0/4] emacs: avoid type errors due to nil as content-type In-Reply-To: References: <20210110184722.29294-1-jonas@bernoul.li> Date: Sun, 10 Jan 2021 21:47:21 +0100 Message-ID: <87r1mstt7q.fsf@bernoul.li> MIME-Version: 1.0 Message-ID-Hash: Z6UMRR75OFB22RMGGPY744BXYMJWG2OY X-Message-ID-Hash: Z6UMRR75OFB22RMGGPY744BXYMJWG2OY X-MailFrom: jonas@bernoul.li X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.09 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=bernoul.li header.s=sel2011a header.b=y/iyLIPO; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 8D00F9402D6 X-Spam-Score: -1.09 X-Migadu-Scanner: scn1.migadu.com X-TUID: Y0rtdtnrh7Tx David Edmondson writes: > On Sunday, 2021-01-10 at 19:47:18 +01, Jonas Bernoulli wrote: > >> The fourth commit tries to address the issue raised in >> id:87k0sxa6c3.fsf@fifthhorseman.net. >> >> The output of "notmuch show --format=sexp --format-version=4" >> may contain `:content-type' entries with `nil' as the value, >> when it fails to detect the correct value. Account for that >> in a few places where we would otherwise risk a type error. >> >> The other three commits cleanup the code I had to look at to do >> the above, because I just can't help myself. >> >> This does not apply without first applying >> id:20201214162401.19569-1-jonas@bernoul.li. > > I don't seem to have this one, but that could be a problem at my end. I am sending you a copy of the original cover letter and I have send v2 of the series earlier today, starting at id:20210110140112.25930-1-jonas@bernoul.li. > Anyway, for the series... > > Reviewed-by: David Edmondson > >> >> Jonas >> >> Jonas Bernoulli (4): >> emacs: notmuch-mua-add-more-hidden-headers: use local binding >> emacs: notmuch-show--register-cids: fix names of bindings >> emacs: notmuch-show--get-cid-content: cosmetics >> emacs: avoid type errors due to nil as content-type >> >> emacs/notmuch-lib.el | 23 ++++++++++++---------- >> emacs/notmuch-mua.el | 7 +++---- >> emacs/notmuch-show.el | 46 +++++++++++++++++++++---------------------- >> 3 files changed, 39 insertions(+), 37 deletions(-) >> >> -- >> 2.30.0 >> _______________________________________________ >> notmuch mailing list -- notmuch@notmuchmail.org >> To unsubscribe send an email to notmuch-leave@notmuchmail.org > > dme. > -- > It was a perfectly good grand piano.