From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 6LQHLnzj/l+wAQAA0tVLHw (envelope-from ) for ; Wed, 13 Jan 2021 12:11:40 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yIsEKnzj/l84MwAAB5/wlQ (envelope-from ) for ; Wed, 13 Jan 2021 12:11:40 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 374B7940105 for ; Wed, 13 Jan 2021 12:11:39 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9B61929EEC; Wed, 13 Jan 2021 07:11:32 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 98F4529D63 for ; Wed, 13 Jan 2021 07:11:30 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id 22FD15FF47; Wed, 13 Jan 2021 07:11:29 -0500 (EST) Received: (nullmailer pid 663491 invoked by uid 1000); Wed, 13 Jan 2021 12:11:27 -0000 From: David Bremner To: Jonas Bernoulli , notmuch@notmuchmail.org Subject: Re: [PATCH v2 00/36] [emacs] Add outline headings and switch to lexical scope In-Reply-To: <20210110140112.25930-1-jonas@bernoul.li> References: <20201214162401.19569-1-jonas@bernoul.li> <20210110140112.25930-1-jonas@bernoul.li> Date: Wed, 13 Jan 2021 08:11:27 -0400 Message-ID: <87r1mp595c.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 7AKPM3AJQTY5X5ANUUEVC3NWHPWLCXBA X-Message-ID-Hash: 7AKPM3AJQTY5X5ANUUEVC3NWHPWLCXBA X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 374B7940105 X-Spam-Score: -1.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5PAGDnSDM+fI Jonas Bernoulli writes: > This fixes a minor whitespace bug that Tomi notices in (1). > > This also adds for commits, two of them in response to a concern > raised by Tomi, who didn't "see enough point for requiring subr-x > just [for string-empty-p]", which I agree with: > > 2) Changes how `cl-lib' and `pcase' are required. I did that first > because I want to do it the same way as for `subr-x'. > > 3) Require `subr-x', so that we can use it without having to worry > whether we have now reached the threshold where it becomes > justified to require an additional library. I pushed applied the first 22 patches to master. "[PATCH v2 23/36] emacs: various cosmetic improvements" leads to some test failures. FWIW, I'm using Emacs 27.1 on Debian testing. T310-emacs: Testing emacs interface FAIL notmuch-fcc-dirs set to a list (with match) --- T310-emacs.28.EXPECTED 2021-01-13 12:00:57.901428602 +0000 +++ T310-emacs.28.OUTPUT 2021-01-13 12:00:57.905428701 +0000 @@ -1,5 +0,0 @@ -From: Notmuch Test Suite -To: -Subject: -Fcc: /home/bremner/software/upstream/notmuch/test/tmp.T310-emacs/mail/sent-list-match ---text follows this line-- *ERROR*: Wrong type argument: listp, "sent-list-match" FAIL notmuch-fcc-dirs set to a list (catch-all) --- T310-emacs.29.EXPECTED 2021-01-13 12:00:57.933429400 +0000 +++ T310-emacs.29.OUTPUT 2021-01-13 12:00:57.933429400 +0000 @@ -1,5 +0,0 @@ -From: Notmuch Test Suite -To: -Subject: -Fcc: /home/bremner/software/upstream/notmuch/test/tmp.T310-emacs/mail/sent-list-catch-all ---text follows this line-- *ERROR*: Wrong type argument: listp, "failure" FAIL notmuch-fcc-dirs set to a list (no match) --- T310-emacs.30.EXPECTED 2021-01-13 12:00:57.953429900 +0000 +++ T310-emacs.30.OUTPUT 2021-01-13 12:00:57.957430000 +0000 @@ -1,4 +0,0 @@ -From: Notmuch Test Suite -To: -Subject: ---text follows this line-- *ERROR*: Wrong type argument: listp, "failure"