unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: fix call to nonexistent notmuch--call-process-shell-command
@ 2021-10-18  4:30 Doug Woos
  2021-10-18 16:49 ` David Bremner
  2021-10-19 12:34 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: Doug Woos @ 2021-10-18  4:30 UTC (permalink / raw)
  To: notmuch; +Cc: Doug Woos

Looks like a find/replace error in e722b4f4
---
 emacs/notmuch-show.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index ea20ddce..4de3e423 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -2086,7 +2086,7 @@ message."
 	  ;; Use the originating buffer's working directory instead of
 	  ;; that of the pipe buffer.
 	  (cd cwd)
-	  (let ((exit-code (notmuch--call-process-shell-command shell-command nil buf)))
+	  (let ((exit-code (call-process-shell-command shell-command nil buf)))
 	    (goto-char (point-max))
 	    (set-buffer-modified-p nil)
 	    (unless (zerop exit-code)
-- 
2.29.2

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: fix call to nonexistent notmuch--call-process-shell-command
  2021-10-18  4:30 [PATCH] emacs: fix call to nonexistent notmuch--call-process-shell-command Doug Woos
@ 2021-10-18 16:49 ` David Bremner
  2021-10-19 12:34 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2021-10-18 16:49 UTC (permalink / raw)
  To: Doug Woos, notmuch; +Cc: Doug Woos

Doug Woos <doug.woos@gmail.com> writes:

> Looks like a find/replace error in e722b4f4
> ---
>  emacs/notmuch-show.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index ea20ddce..4de3e423 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -2086,7 +2086,7 @@ message."
>  	  ;; Use the originating buffer's working directory instead of
>  	  ;; that of the pipe buffer.
>  	  (cd cwd)
> -	  (let ((exit-code (notmuch--call-process-shell-command shell-command nil buf)))
> +	  (let ((exit-code (call-process-shell-command shell-command nil buf)))
>  	    (goto-char (point-max))
>  	    (set-buffer-modified-p nil)
>  	    (unless (zerop exit-code)
> -- 
> 2.29.2

That looks good to me. If there are no objections today, I'll apply this
for the upcoming release.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: fix call to nonexistent notmuch--call-process-shell-command
  2021-10-18  4:30 [PATCH] emacs: fix call to nonexistent notmuch--call-process-shell-command Doug Woos
  2021-10-18 16:49 ` David Bremner
@ 2021-10-19 12:34 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2021-10-19 12:34 UTC (permalink / raw)
  To: Doug Woos, notmuch; +Cc: Doug Woos

Doug Woos <doug.woos@gmail.com> writes:

> Looks like a find/replace error in e722b4f4

applied to master and release

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-19 12:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18  4:30 [PATCH] emacs: fix call to nonexistent notmuch--call-process-shell-command Doug Woos
2021-10-18 16:49 ` David Bremner
2021-10-19 12:34 ` David Bremner

Code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).