From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iKybFg14U2L0xwAAgWs5BA (envelope-from ) for ; Mon, 11 Apr 2022 02:36:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id mMgdEw14U2LVZQAAauVa8A (envelope-from ) for ; Mon, 11 Apr 2022 02:36:29 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9DE35363E8 for ; Mon, 11 Apr 2022 02:36:28 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 7222E5F525; Mon, 11 Apr 2022 00:36:23 +0000 (UTC) Received: from che.mayfirst.org (che.mayfirst.org [IPv6:2001:470:1:116::7]) by mail.notmuchmail.org (Postfix) with ESMTPS id C59A05E017 for ; Mon, 11 Apr 2022 00:36:15 +0000 (UTC) Received: from fifthhorseman.net (cpe-76-167-129-203.san.res.rr.com [76.167.129.203]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id E2056F9B0; Sun, 10 Apr 2022 20:36:12 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id D36012048D; Sun, 10 Apr 2022 17:35:54 -0700 (PDT) From: Daniel Kahn Gillmor To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] test/smime: fix signature verification test with newer gmime. In-Reply-To: <20220409123453.606391-2-david@tethera.net> References: <874k3pvrfq.fsf@tethera.net> <20220409123453.606391-1-david@tethera.net> <20220409123453.606391-2-david@tethera.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH Date: Sun, 10 Apr 2022 17:35:53 -0700 Message-ID: <87r164mp7a.fsf@fifthhorseman.net> MIME-Version: 1.0 Message-ID-Hash: 6FLEZLSBLRNP6JQ7VBKATWSYVCQ5QMXA X-Message-ID-Hash: 6FLEZLSBLRNP6JQ7VBKATWSYVCQ5QMXA X-MailFrom: dkg@debian.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============4946147568502856916==" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649637389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:autocrypt:autocrypt; bh=9f0I2eMtwEzVYcP7GDP83JlbRxJjxjQfFIa+wF8PzFo=; b=SA/DB0BB+nCzb9JnuhFOalxZ0iFEwjxXaZob1PeQkyKSJhxLLY/ohPcC6kdRxfnhlGq2Wc xtCiS2KxodD75bfGAqZEmBzEJAb5zpIRcjYSke6iQfl+kl4gEAw4sK0a/weTZcIiwgo4qf 38wSYporSPl5y0dA6CWbrZDa2QmxksAS1v1k1q+UqOS7ZYtfyenyEwZCLDAZDesMITCI3m 2yCnLTa3LnEBWG0muSiEYLGZhRQnJF+awxpErIsByM7cEC4/NGEobO7SItMVqohHeUXkTv qhxyMcp0T4IWqKsitDIUJNq7ctndhM8lEJRsLjmf2kq8tZZ2+/H3jbm5dYiDyA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649637389; a=rsa-sha256; cv=none; b=FNE3iXFLvFd9KyLSlEjkS4Bdy95GsDFvR9ivSxAr4LpEg3ibnTUCQSGp0NQrrxkEdrHNtW 5vLQK++wQcKm8Pcm59rWSnSQatXdeLl1U97A6cCFNjpshE9OkULygGIdQJAm/lq3Xlorih I5tujM7b+u7dghTKB0fFUE+CkbdnaKFOVI3yMNJKhjhj4cFbbh7BY+Z0mqer9hx1ak2aeJ MOl0DM1PCyPth0Q/rFZbPnxKO+JNu9LQT+3CXEjz3U7IRc+m2lhK30q79aCVJWpOvC/8Mu qKsAwfF02dJmRoFXKM+UGlDpTfKh5klefC6hywfg0TdvTJ8f4ODt3e2BzRRO8Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.68 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 9DE35363E8 X-Spam-Score: -2.68 X-Migadu-Scanner: scn1.migadu.com X-TUID: wX5buYYxxVb7 --===============4946147568502856916== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Thanks, Bremner! This series looks reasonable to me. nice clever hack to reuse the gmime embedded .c source for the test. a bit of a tweak below: On Sat 2022-04-09 09:34:53 -0300, David Bremner wrote: > + printf "Checking for GMime new email format... " > + if ${CC} -DCHECK_EMAIL ${CFLAGS} ${gmime_cflags} _check_gmime_cert.c ${gmime_ldflags} -o _check_email && > + GNUPGHOME=${TEMP_GPG} ./_check_email; then > + gmime_new_email_format=1 > + printf "Yes.\n" > + else > + gmime_new_email_format=0 > + printf "No (some tests will be skipped).\n" > + fi > else > printf 'No.\nFailed to set up gpgsm for testing X.509 certificate validity support.\n' > errors=$((errors + 1)) Words like "new" have a tendency to get, well, old. I'd say "Checking GMime emits email addresses from certs without angle brackets..." And i'd name the variable gmime_cert_addresses_have_angle_brackets (so "1" effectively means "probably a stale, deprecated version of GMime"). Then change the rest of the tests to match. This is kind of an aesthetic choice -- i'd be fine with the original patch too. but it seems safer to just identify the out-of-date stuff when it happens, rather than identifying the current stuff. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCYlN36gAKCRA+nXFzcd5W XLBMAQCCY9k1qN2r9husGadDo1fn6//p8J4qbkkM3RAbx7ydTAEAtBZMefuxRxrq R1bWrmlitpLf7a0EgRYLOx8ZTsGasAo= =YDDP -----END PGP SIGNATURE----- --=-=-=-- --===============4946147568502856916== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============4946147568502856916==--