[PATCH] emacs: Don't eat last newline character of citations

[PATCH] emacs: Don't eat last newline character of citations

[Kan-Ru Chen]

In case of a citation following immediately new contents. When the citation
was collapsed:

    [1-line citation. Click/Enter to show.]
Lorem ipsum dolor sit amet, consectetur adipisicin

When it was expanded:

    [10-line citation. Click/Enter to show.]
    >
    Lorem ipsum dolor sit amet, consectetur adipisicin

The indentation was wrong.

Signed-off-by: Kan-Ru Chen <kanru@kanru.info>
---
 notmuch.el |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/notmuch.el b/notmuch.el
index 97914f2..aa6bc60 100644
--- a/notmuch.el
+++ b/notmuch.el
@@ -606,6 +606,7 @@ which this thread was originally shown."
 	    (while (looking-at citation)
 	      (forward-line)
 	      (move-to-column depth))
+	    (end-of-line 0)
 	    (let ((overlay (make-overlay beg-sub (point)))
                   (invis-spec (make-symbol "notmuch-citation-region")))
               (add-to-invisibility-spec invis-spec)
-- 
1.6.5.5

Re: [PATCH] emacs: Don't eat last newline character of citations

[Carl Worth]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

On Mon, 14 Dec 2009 00:06:53 +0800, Kan-Ru Chen <kanru@kanru.info> wrote:
> In case of a citation following immediately new contents. When the citation
> was collapsed:
> 
>     [1-line citation. Click/Enter to show.]
> Lorem ipsum dolor sit amet, consectetur adipisicin

That's definitely a bug we want to fix, yes.

But the patch also makes many cases display with two lines between the
citation button and the subsequent, non-citation content (where the
original message has just one).

That extra blank line has been annoying me, and it was probably my
effort to get rid of it that introduced the bug above.

If we could get rid of both bugs at the same time, that would be ideal.

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]